Skip to content

Commit 786ffd3

Browse files
committed
style: ipml from trait
1 parent df6e386 commit 786ffd3

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

monoio-http-client/src/client/connector.rs

+3-5
Original file line numberDiff line numberDiff line change
@@ -246,16 +246,14 @@ impl<TC, K, IO: AsyncWriteRent> std::fmt::Debug for PooledConnector<TC, K, IO> {
246246
write!(f, "PooledConnector")
247247
}
248248
}
249-
pub trait NewTlsStream {
250-
fn new(config: ConnectionConfig) -> Self;
251-
}
249+
252250
impl<TC, K: 'static, IO: AsyncWriteRent + 'static> PooledConnector<TC, K, IO>
253-
where TC:NewTlsStream
251+
where TC : From<ConnectionConfig>
254252
{
255253
pub fn new_default(global_config: ClientGlobalConfig, c_config: ConnectionConfig) -> Self {
256254
Self {
257255
global_config,
258-
transport_connector: TC::new(c_config.clone()),
256+
transport_connector: TC::from(c_config.clone()),
259257
http_connector: HttpConnector::new(c_config),
260258
pool: ConnectionPool::default(),
261259
}

monoio-http-client/src/client/unified.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ use monoio::{
1313
use service_async::Param;
1414
use smol_str::SmolStr;
1515

16-
use super::connector::{NewTlsStream, TcpConnector, TlsConnector, TlsStream, UnixConnector};
16+
use super::{connector::{TcpConnector, TlsConnector, TlsStream, UnixConnector}, ConnectionConfig};
1717
use crate::Connector;
1818

1919
// TODO: make its PathBuf and SmolStr to ref
@@ -57,8 +57,8 @@ pub struct UnifiedTransportConnector {
5757
unix_tls: TlsConnector<UnixConnector>,
5858
}
5959

60-
impl NewTlsStream for UnifiedTransportConnector{
61-
fn new(config: super::ConnectionConfig) -> Self {
60+
impl From<ConnectionConfig> for UnifiedTransportConnector{
61+
fn from(config: ConnectionConfig) -> Self {
6262
UnifiedTransportConnector{
6363
tcp_tls: TlsConnector::<TcpConnector>::new(&config),
6464
unix_tls: TlsConnector::<UnixConnector>::new(&config),

0 commit comments

Comments
 (0)