bug: API returning status ok when not using overwrite

[mbevc1]

As I was adding features following mbevc1/tdns#2 I've noticed the following behaviour:

• When adding an A record via API that already exists without overwrite flag, response is ok but nothing is changed. This seems like a bug and it should return failed with an error that record already exists.

[mbevc1]

Noticed something similar with deleting the record - when record doesn't existing response is still ok, where I'd expect getting an error saying it doesn't exist.

[ShreyasZare]

Thanks for the feedback. The overwrite option is to overwrite all existing records for the same type, i.e. to replace the entire resource record set with the new record. So, if the domain already had 2 A records and you use the overwrite flag to add another A record then the old records would get removed and only the one added would exist. When the flag is not set, the record is added to the resource record set so if you had 2 A records earlier then the call would result in having 3 A records.

When you try to add a record which already exists, it just gets de-duplicated while being added so the end result is that you see no change. This is not considered an error just to avoid complications in places where such an error would break things.

For the delete call, the API does not return any errors when the record does not exist. This was done since the GUI may have stale values and if a user tries to delete a record which does not exists, it would be done without giving an error just to avoid any annoyance.

[mbevc1]

Thanks for the additional context. Just to provide more info based on my observations working on tdns:

• adding new record not using override is not duplication the record, nor error is returned. therefore I found it a bit confusing as nothing was done.
• on the delete I reckon this should be handled in UI, e.g. if there are stale records and user tries to delete those we could ignore those errors or filter out only non-existing ones but error on others? Currently seems there is not feedback from API if record is missing. I mean not the worst thing, but just feels like low error coverage

[ShreyasZare]

Will evaluate these calls once and see if they can be updated without affecting anything.

[ShreyasZare]

Technitium DNS Server v13.5 is now available that changes the delete API to return error when record does not exists. The add API remains same since changing its behavior breaks the update record mechanism. Do update and let me know your feedback.

[mbevc1]

Will do, thanks @ShreyasZare !

[ShreyasZare]

I did not have much time earlier but after revisiting this issue, I found another way the Add API call can be changed to return error if record already exists. Will get the changes for Add API done in the next update.

[mbevc1]

Cool, thanks for exploring new options here. If you're changing API, could you make sure APIDOCS are updated? I should dig out my notes, there are some minor inconsistencies there, are you accepting PRs?

Good work with the latests release and looking forward to the next one!

[ShreyasZare]

Cool, thanks for exploring new options here. If you're changing API, could you make sure APIDOCS are updated? I should dig out my notes, there are some minor inconsistencies there, are you accepting PRs?

Good work with the latests release and looking forward to the next one!

The Add API wont have any changes, it will just return error status if the record already exists. I can accept PR but it will be best if you can let me know the exact issue so that I can check it.

[mbevc1]

Okay, I'll parse for errorStatus. Sure, happy to also open an issue.

[ShreyasZare]

Technitium DNS Server v13.6 is now available that now changes the Add API to return error if record being added already exists. Do update and let me know your feedback.

[mbevc1]

Awesome, thanks! Both add and delete work as expected now and return errors when records either exist or not present. 🚀