Skip to content

Commit ad82989

Browse files
committed
Merge branch 'feat/averiewang/support-bm25' into 'main' (merge request !54)
feat: hybridSearch ann must be vector
2 parents 960eb97 + c640c1e commit ad82989

File tree

2 files changed

+8
-12
lines changed

2 files changed

+8
-12
lines changed

tcvectordb/base_document.go

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -153,11 +153,10 @@ type MatchOption struct {
153153
}
154154

155155
type AnnParam struct {
156-
FieldName string
157-
DocumentIds []string
158-
Data interface{}
159-
Params *SearchDocParams
160-
Limit *int
156+
FieldName string
157+
Data interface{}
158+
Params *SearchDocParams
159+
Limit *int
161160
}
162161

163162
func (i *implementerDocument) HybridSearch(ctx context.Context, params HybridSearchDocumentParams) (*SearchDocumentResult, error) {
@@ -430,17 +429,15 @@ func (i *implementerFlatDocument) HybridSearch(ctx context.Context, databaseName
430429
fieldName = annParam.FieldName
431430
}
432431
req.Search.AnnParams = append(req.Search.AnnParams, &document.AnnParam{
433-
FieldName: fieldName,
434-
DocumentIds: annParam.DocumentIds,
435-
Limit: annParam.Limit,
432+
FieldName: fieldName,
433+
Limit: annParam.Limit,
436434
})
437435

438436
req.Search.AnnParams[i].Data = make([]interface{}, 0)
439-
440437
if vec, ok := annParam.Data.([]float32); ok {
441438
req.Search.AnnParams[i].Data = append(req.Search.AnnParams[i].Data, vec)
442439
} else {
443-
return nil, fmt.Errorf("hybridSearch failed, because of AnnParam.Vectors field type, " +
440+
return nil, fmt.Errorf("hybridSearch failed, because of AnnParam.Data field type, " +
444441
"which must be []float32")
445442
}
446443

tcvectordb/rpc_base_document.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -235,8 +235,7 @@ func (r *rpcImplementerFlatDocument) HybridSearch(ctx context.Context, databaseN
235235
fieldName = annParam.FieldName
236236
}
237237
req.Search.Ann = append(req.Search.Ann, &olama.AnnData{
238-
FieldName: fieldName,
239-
DocumentIds: annParam.DocumentIds,
238+
FieldName: fieldName,
240239
})
241240
if annParam.Limit != nil {
242241
req.Search.Ann[i].Limit = uint32(*annParam.Limit)

0 commit comments

Comments
 (0)