Skip to content

Conversation

@pjonsson
Copy link
Contributor

What this PR does

The 3.x release uses ES
Modules and contains type
annotations in the main
package.

Test me

This dependency is used by buildprocess/patchNetworkRequests.ts.

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

The 3.x release uses ES
Modules and contains type
annotations in the main
package.
@zoran995
Copy link
Collaborator

@nf-s you worked most on this, do you have any suggestions on the best way to test this?
p.s. I wonder if we can replace node-fetch with the native fetch in modern Node. If possible, we could consider doing this as a follow-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants