Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code Review] Remove the usage of "partial" and other coding style issues. #41

Open
jasonkuo41 opened this issue Feb 8, 2020 · 0 comments
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed

Comments

@jasonkuo41
Copy link

partial keyword is meant to be used when compiling to different target framework, platform, and configuration and is not to be abused like it is in this project.

Also, keep each class per file. Although it's sometimes acceptable to do so given certain reasons as long as they are consistent, in this project is doesn't seem like it.

Nested class should either be at the front, or at the end of the class and shouldn't be placed at anywhere else and should be consistent across the project.

Naming conventions are also not consistent. Some classes are camelCases while most are PascalCases. Microsoft and I both recommend using PascalCase across the board.

@TeunvandenBroek TeunvandenBroek added documentation Improvements or additions to documentation help wanted Extra attention is needed labels Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants