Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MyAnimeList support #134

Open
Zabooby opened this issue Apr 10, 2022 · 18 comments
Open

MyAnimeList support #134

Zabooby opened this issue Apr 10, 2022 · 18 comments
Labels
enhancement New feature or request help wanted Extra attention is needed invalid This doesn't seem right

Comments

@Zabooby
Copy link

Zabooby commented Apr 10, 2022

Is support MAL sync planned?

@Zabooby Zabooby added the enhancement New feature or request label Apr 10, 2022
@ThaUnknown
Copy link
Owner

no, MAL API is just dogshit [on the rare occasion it works], and I don't want to rely on fan-made 3rd part API's for MAL

however AniList exposes MAL ID's for most anime, so someone could easily make a PR based on that, which I'd likely accept

invalid issue template

@ThaUnknown ThaUnknown reopened this Apr 10, 2022
@ThaUnknown ThaUnknown added the help wanted Extra attention is needed label Apr 10, 2022
@Zabooby
Copy link
Author

Zabooby commented Apr 10, 2022

Couldn't you just copy taiga's implementation of MAL,they seem to have it working?

https://github.com/erengy/taiga

@ThaUnknown
Copy link
Owner

image
image
no lol

@ThaUnknown ThaUnknown added the invalid This doesn't seem right label Apr 10, 2022
@Zabooby
Copy link
Author

Zabooby commented Apr 10, 2022

Here is some documentation on their api, might help.

https://myanimelist.net/apiconfig

@ThaUnknown
Copy link
Owner

Here is some documentation on their api, might help.

https://myanimelist.net/apiconfig

image

@Zabooby
Copy link
Author

Zabooby commented Apr 10, 2022

@Zabooby
Copy link
Author

Zabooby commented Apr 10, 2022

Nvm I checked the video, have you tried using a different browser or I could send you a html file of the docs if you want.

@ThaUnknown
Copy link
Owner

Nvm I checked the video, have you tried using a different browser or I could send you a html file of the docs if you want.

that video is the perfect example of why I don't bother supporting MAL, if some1 makes a PR for it, I'll accept it, but I don't plan on working on it myself

@Olyno
Copy link

Olyno commented Apr 14, 2022

Hi 👋🏻
I would add Anilist too if possible. MyAnimeList starts to be deserted more and more to go for Anilist, which is more modern in every sense. Note that the Anilist api is particularly simple, hence the reason for my proposal.

@ThaUnknown
Copy link
Owner

Hi 👋🏻 I would add Anilist too if possible. MyAnimeList starts to be deserted more and more to go for Anilist, which is more modern in every sense. Note that the Anilist api is particularly simple, hence the reason for my proposal.

I recommend u read the list of features https://github.com/ThaUnknown/miru#features
anilist is already supported, idk how u missed the big ass "login with anilist" button in the corner

@Olyno
Copy link

Olyno commented Apr 14, 2022

Oops sorry I didn't see it, I just stumbled upon this issue by chance, I should have been more careful, my apologies

@Zabooby
Copy link
Author

Zabooby commented Apr 29, 2022

@YUKI2eN3e
Copy link

image image no lol

Maybe I'm completely misunderstanding how it works (I've only looked into Wasm pretty briefly), but couldn't you compile the C++/C code to Wasm and use it with your JavaScript code that way?

@ThaUnknown
Copy link
Owner

ThaUnknown commented May 6, 2022

wow i cringed

It's not that its not possible in JS, its that i cant be fucking arsed to do it, because of how dogshit MAL is

@Zabooby Zabooby closed this as completed May 6, 2022
@ghost
Copy link

ghost commented May 7, 2022

Reopening this since its a good feature that many people would benefit from. It's not impossible, just troublesome because MAL has chosen it to be.
As ThaUnknown said, he won't work on it himself but will accept PRs if someone else is willingly to implement.

@ghost ghost reopened this May 7, 2022
@Atkoset
Copy link

Atkoset commented Jun 4, 2022

Hello, could you add Kitsu API too if possible? Kitsu is comparable to Anilist in the way that it also syncs your anime. Where it differs is that it's fully opensource option that a lot of people including me use since it's opensource it shouldn't take too much work to integrate I hope. I have included a link to their API repo below.

https://github.com/hummingbird-me/api-docs

@ThaUnknown

@ThaUnknown
Copy link
Owner

as I stated before, I won't be pursuing this, but I'm open to accept PRs for it

Repository owner locked as spam and limited conversation to collaborators Jun 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

5 participants