Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Portable Version installs when newer version available (Update functionality) #445

Open
3 tasks done
EpicGazel opened this issue Apr 21, 2024 · 7 comments
Open
3 tasks done
Labels
bug Something isn't working external This issue is caused by external dependencies, not the app itself.

Comments

@EpicGazel
Copy link

Preflight checklist

  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.
  • I have searched the frequently asked questions for a solution that fixes this problem, without success.
  • I have checked that I'm using the latest stable version of the app.

What app version are you using?

v5.0.12

What operating system version are you using?

Windows

Expected Behavior

The portable version should not attempt to and successfully install an updated version upon closing.

Actual Behavior

While running the portable version, an update will be found, downloaded, and installed upon closing. This adds files and a desktop icon, all of which are unprompted.

Screenshots

No response

@EpicGazel EpicGazel added the bug Something isn't working label Apr 21, 2024
@ThaUnknown ThaUnknown added the external This issue is caused by external dependencies, not the app itself. label Apr 21, 2024
@vvirtues
Copy link

vvirtues commented May 8, 2024

might not be directly related but the winget repo uses the portable instead of the installer , I can update that if you want

@vvirtues
Copy link

vvirtues commented May 8, 2024

Review if you want it: microsoft/winget-pkgs#152606

@ThaUnknown
Copy link
Owner

this should be fixed in 5.1.2, but since it's fixed in that version, we'll need to wait for 5.1.3 to verify if it was actually fixed

@EpicGazel
Copy link
Author

Still not fixed going from 5.1.3 -> 5.1.4

@EpicGazel
Copy link
Author

Still not fixed going from 5.1.4 -> 5.1.6

@ThaUnknown
Copy link
Owner

this is unlikely to be fixed, since it's an issue with electron build dependencies, not miru itself

@EpicGazel
Copy link
Author

EpicGazel commented Jul 1, 2024

Band-aid solution for others: delete or rename %localappdata%/miru-updater
Remove user permissions from %localappdata%/miru-updater, then miru won't be able to download or access the installer.
No installer.exe means no install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working external This issue is caused by external dependencies, not the app itself.
Projects
None yet
Development

No branches or pull requests

3 participants