Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation tooltip is triggered even when CVE Score is valid #97

Closed
AlvinAtThales opened this issue Jun 30, 2023 · 1 comment · Fixed by #261
Closed

Validation tooltip is triggered even when CVE Score is valid #97

AlvinAtThales opened this issue Jun 30, 2023 · 1 comment · Fixed by #261
Assignees
Labels
bug Something isn't working medium Medium priority

Comments

@AlvinAtThales
Copy link
Contributor

Version: 1.0.1

Issue description:
When the CVE score is a floating integer within 9 decimal places, a validation tooltip stating "Please enter a valid value. The two nearest valid values are..." will be shown on hover.

Duplicate Steps:
Go to CVE Official CVSS Score under Vulnerabilities Tab and input a value that has a decimal place between 0 to 10. Hover on the text box, a validation tooltip will be displayed.

Expected Result:
There should not be a validation tooltip as the value is valid.

Attachments:
image

@AlvinAtThales AlvinAtThales self-assigned this Jun 30, 2023
@AlvinAtThales AlvinAtThales added bug Something isn't working medium Medium priority labels Jun 30, 2023
@AlvinAtThales AlvinAtThales linked a pull request Aug 2, 2023 that will close this issue
@ThomasDThales ThomasDThales linked a pull request Apr 22, 2024 that will close this issue
@CarlatThales
Copy link
Contributor

CarlatThales commented Apr 24, 2024

After review of the fix, this would require a step of 0.000000001 which would render the control unusable. The decision has been made to have a step of 0.1. This would require a change in JSON validation where the value will be truncated to one decimal digit and and the input will only allow this. This is a change in behavior with minimal impact to the functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment