Legion intro

[atidot3]

Description:

Legion introduction quest is not functionnal.

Tested with human after doing the first quest at stormwind you talk to the captain then have a cinematic and get teleported to the water with a LFG scenario that never procs.

Expected behaviour:

Have the scenario ready + teleported at the end of the cinematics.

Steps to reproduce the problem:

as explained

LC rev. hash/commit:
1298ba9

Operating system:

win

[atidot3]

After several debugging it seems the transport for ids:
TRANSPORT_ALLIANCE = 251513
TRANSPORT_HORDE = 254124

Are not spawn correctly on the instance:
InitializeTransport()
MapID 1460 InstanceID 1
transportGameObject alliance 251513 nullptr
transportGameObject horde 254124 nullptr
Transport* transport = player->GetMap()->GetTransport(transportGuid) IS NULLPTR

`void InitializeTransport(Player* player)
{
TC_LOG_ERROR("scripts", "InitializeTransport()");
TC_LOG_ERROR("scripts", "MapID %u InstanceID %u", player->GetMapId(), player->GetInstanceId());

        auto transportGameObjectA = GetGameObjectByEntry(TRANSPORT_ALLIANCE);
        if (!transportGameObjectA)
        {
            GameObject* go = player->SummonGameObject(TRANSPORT_ALLIANCE, 2.39286f, 1.69455f, 5.20573f, 3.15592f, 0, 0, 0, 0, 0);
            if (go)
            {
                go->SetPhaseMask(1, true); // Activation de la phase pour rendre l'objet visible
                transportGameObjectA = go;
            }
            else
                TC_LOG_ERROR("scripts", "transportGameObject alliance %u nullptr", TRANSPORT_ALLIANCE);
        }

        auto transportGameObjectH = GetGameObjectByEntry(TRANSPORT_HORDE);
        if (!transportGameObjectH)
        {
            GameObject* go = player->SummonGameObject(TRANSPORT_HORDE, -11.262f, -7.55103f, 11.557f, 4.48529f, 0, 0, 0, 0, 0);
            if (go)
            {
                go->SetPhaseMask(1, true); // Activation de la phase pour rendre l'objet visible
                transportGameObjectH = go;
            }
            else
                TC_LOG_ERROR("scripts", "transportGameObject horde %u nullptr", TRANSPORT_HORDE);
        }

}`

I've noticed this issue when trying to understand why at this line it was nullptr
https://github.com/The-Legion-Preservation-Project/LegionCore-7.3.5/blob/main/src/server/scripts/Scenario/BrokenIslands/instance_broken_islands.cpp#L99