Bzlmod porting.

[lromor]

Hi, I ported the dependencies of this project and this project to bzlmod at:
https://github.com/amorphic-io/OpenROAD/tree/bzlmodify

Most of the dependencies needs to be overriden but I think it could be a good starting point to simplify the import of OpenROAD (and rules_hdl) in other bazel projects.

I would love to merge these changes in the respective transitive and direct deps repos and/or in BCR but it requires some effort.

[oharboe]

Interesting!

Normally I would expect a pull request for a branch such as this.

Are you planning to make one or more pull requests?

[maliberty]

I would like to see a PR as well. I see you also have some changes for new flags that would be good to separate out. Is that something you are willing to do?

[lromor]

Hi @oharboe , @maliberty ! Yes, I would love to see this merged. Right now as you can see there's some work scattered on many different projects.

I would love to hear your opinion on how to proceed.

I see two different routes:

1. PR with MODULE overrides for dependencies not yet merged in BCR pointing to my repos.
2. Define a roadmap to merge the direct/transitive deps first and then open a PR here.

What do you think?
Adding @hzeller and @mithro here in case they are interested.

[oharboe]

If possible, create single concern independent PRs so that we can have as much go in as possible and then worry about the bigger fish separately...

OpenROAD has traditionally forked git projects where needed for stability of dependencies. I'm thinking that if you create the PR with your own repositories, they can be forked by the OpenROAD project, if needed, while we wait for things to trickle int BCR.

So my thinking is to go with 1. above and then whittle away at things, forking dependencies as needed, and switch to BCR when it becomes available.

Getting rid of WORKSPACE would be a big boon. OpenROAD itself can then be used from another MODULE.bazel...

[lromor]

Great! I'll do my best to prepare a PR this weekend.

[maliberty]

Do you have a list of open PRs to BCR? @QuantamHD might be able to help move them through. If we can do that quickly it would avoid the two-step of forking and then updating to BCR later.

[lromor]

I do not have any PR open in BCR.

• tcl: bzlmod.
• swig: exists in bcr, added lib_tcl.
• llvm-project: bumped version + bzlified openmp runtime.
• rules_cc: nix fix.
• abc: bzlmod.
• ncurses: added a fix for nixos. Recently a patch might already fix this.
• lemon: bzlmod.

I think I can start with tcl.

[lromor]

I decided to proceed in the following way.

1. I'm working on a tool to simplify the bcr modules generation process made in rust. It iterates through my branch patches, parses the summary and tries to generate a compliant bcr module.
2. Update my bcr fork so you can start using my overlayed modules without MODULE overrides.
3. Open a PR against OpenRoad to include the changes I made to the project.
4. Open a PR against bazel-central-registry to add/bump the new modules.

Today I mostly worked on 1.

[maliberty]

Any updates?

[lromor]

Sorry, busy period! I did get the chance to work a bit on porting the latest release of llvm-project:
https://github.com/amorphic-io/llvm-project/tree/bzlmodify-20.1.8 instead of using an untagged commit.
I still need to add the libopenmp runtime. Some of the llvm-project tests are failing.

I kept working a bit more on the rust bazel-bcr-helper.

[lromor]

I managed to get a clean set of patches and fixed an issue for llvm-project that would not build when using ld.gold. All tests seem to be passing now.

[lromor]

Someone independently just added tcl: https://github.com/bazelbuild/bazel-central-registry/pull/5369/files