Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] invalid test test_generate_api_key_invalid_prefix_type - should be removed #14

Open
evelynmitchell opened this issue Dec 22, 2023 · 1 comment
Assignees
Labels
bug Something isn't working Fund no-issue-activity

Comments

@evelynmitchell
Copy link
Contributor

evelynmitchell commented Dec 22, 2023

From within a container, python 3.10.13

pytest test_api_generator.py 
================================ test session starts ================================
platform linux -- Python 3.10.13, pytest-7.4.3, pluggy-1.3.0
rootdir: /usr/src/swarm_cloud/tests
plugins: time-machine-2.13.0, anyio-3.7.1
collected 18 items                                                                  

test_api_generator.py F...F...EF.F.F...F                                      [100%]
===================================== FAILURES ======================================
_____________________ test_generate_api_key_invalid_prefix_type _____________________

    def test_generate_api_key_invalid_prefix_type():
        with pytest.raises(ValueError):
>           generate_api_key(prefix=123)

This test is expecting to receive a value error for generating an api key with prefix 123. But, there is no standards for the values that an API key can take, so this test will never raise a Value Error, and should be removed.

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@evelynmitchell evelynmitchell added the bug Something isn't working label Dec 22, 2023
Copy link

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Fund no-issue-activity
Projects
None yet
Development

No branches or pull requests

2 participants