Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue with AVL tree del_node function causing RL rotation asser… #11530

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed issue with AVL tree del_node function causing RL rotation asser… #11530

wants to merge 2 commits into from

Conversation

essashahid
Copy link

Describe your change:

This PR fixes the assertion error in the del_node function of the AVL tree implementation. The issue occurred during RL rotation when deleting a node. The fix ensures that the correct height calculations and rotations are performed, preventing the assertion error.

  • Fix a bug or typo in an existing algorithm

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes Error in AVL_Tree del_node function #11502".

@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Aug 26, 2024
imSanko
imSanko suggested changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@imSanko imSanko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check with this : PLR5501 Use elifinstead ofelsethenif, to reduce indentation and while re-run with the test cases!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imSanko imSanko imSanko requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
tests are failing Do not merge until tests pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in AVL_Tree del_node function
2 participants
@essashahid @imSanko