Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to do about project euler solution pull requests #8990

Open
CaedenPH opened this issue Aug 18, 2023 · 2 comments
Open

What to do about project euler solution pull requests #8990

CaedenPH opened this issue Aug 18, 2023 · 2 comments
Labels
awaiting triage Awaiting triage from a maintainer

Comments

@CaedenPH
Copy link
Contributor

What would you like to share?

The following prs implement solutions to project euler problems:

These prs either haven't been reviewed or haven't been merged. What should be done about these prs?

Additional information

No response

@CaedenPH CaedenPH added the awaiting triage Awaiting triage from a maintainer label Aug 18, 2023
@tianyizheng02
Copy link
Contributor

@dhruvmanila Could you review these open Project Euler PRs?

@dhruvmanila
Copy link
Member

I'll probably be able to spend some time here in a few weeks onwards, can't say for sure 😅

Regarding Project Euler problems, I'm no expert but found them interesting enough to own reviewing such solutions. This doesn't mean no other person can review, I'm totally ok with that. A suggestion is to not allow additional solutions for the same problem as usually they'll be similar. It's much better to improve an existing solution instead. I hope you understand :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting triage Awaiting triage from a maintainer
Projects
None yet
Development

No branches or pull requests

3 participants