-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FacesMessages, <b:messages /> & <b:message /> #1000
Comments
@edburns @tandraschko @BalusC @arjantijms @cagataycivici Mind to chime in? Adding a "success" severity for FacesMessages sounds like a good idea to me. So what's the reason why the proposal ticket has been closed in the JSF spec project? |
>>>> On Mon, 27 Aug 2018 15:10:58 -0700, Stephan Rauh ***@***.***> said:
SR> @edburns @tandraschko @BalusC @arjantijms @cagataycivici Mind to chime in?
SR> Adding a "success" severity for FacesMessages sounds like a good idea to me. So what's the reason why the proposal ticket has been closed in the JSF spec project?
I like the idea also. However, I will defer to @arjantijms to explain
the closure reason. Perhaps it is due to issue tracker consolidation?
Ed
…--
| [email protected] | office: +1 407 458 0017
|
I really like the idea as well. The way faces messages are currently being handled is perhaps not entirely optimal. In fact, it was one of the earliest criticisms against JSF (e.g. by Matt Raible) that still hasn't really been addressed today (as opposed to most other things where @edburns et al did an amazing job). I'm not sure why the original issue was closed, but this was done a long time ago. It was set as fixed on the very same day as it was reported: It was then closed, probably automatically, 4 years later: The general topic of "messages" and then specifically this issue about severity would be absolutely great to include in the next version of JSF. If the other JSF committers agree, then I'd surely think this has a good chance to be included indeed. |
+1 |
+1 |
+1 |
Bootstrap has 4 types of alerts (success, info, warning & danger), whereas BootsFaces implements 3 types of alerts(info, warning & error), why there is no success alert.
FacesMessage
severityerror
&fatal
are implemented asalert-danger
.There is an issue of JavaServer Faces Add new FacesMessage Severity "SUCCESS" #895, and it is closed.
I propose adding a new severity
SUCCESS
tonet.bootsfaces.utils.FacesMessages
,<b:messages />
&<b:message />
The text was updated successfully, but these errors were encountered: