Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

input with tags damages the setting process #995

Closed
ghost opened this issue Aug 21, 2018 · 16 comments · May be fixed by #1141
Closed

input with tags damages the setting process #995

ghost opened this issue Aug 21, 2018 · 16 comments · May be fixed by #1141
Assignees
@geopossachs
Labels
bug confirmed wontfix
Milestone
v1.6.0

Comments

@ghost
Copy link

ghost commented Aug 21, 2018 •
edited by ghost
Loading

BootsFaces Version 1.3.0

Assume this simple example:

<b:form>
  <b:inputText tags="true" value="#{myBean.myValue}" />
  <b:commandButton action="#{myBean.submit}" value="submit" />
</b:form>
@ManagedBean
@SessionScoped
public class MyBean {
  private String myValue;
  public String getMyValue(){ return myValue; }
  public String setMyValue(String myValue){ this.myValue = myValue; }
  public String submit() {
    System.out.println(myValue);
  }
}

If the tags-attribute is set to true, the method setMyValue is not used or may be used, but the value does not be submitted. The output is clear for this case.

Removing the tags-attribute activates the setter again.
@stephanrauh
Copy link
Collaborator

My attempt to improve the feature in BootsFaces 1.3.0 has made it worse. I've fixed that in the developer Snapshot of 1.3.1. Would you mind to have a look if the bugs is solved in 1.3.1?

@ghost
Copy link
Author

ghost commented Sep 10, 2018

I'm afraid but it still does not work yet with 1.3.1-SNAPSHOT. The setter is simply not called.

@ghost
Copy link
Author

ghost commented Dec 10, 2018

why has this issue not been solved before 1.4.0 came out?

@stephanrauh
Copy link
Collaborator

I'm sorry. There's a simple reason: we've run out of active developers. Sometimes private life interferes with your passion for open source. Currently, we don't even manage to solve bugs faster than they are reported. Every once in a while I send a tweet asking for a helping hand, but nobody seems to be interested.

So, yes, I'm really sorry for starting to solve your ticket, only to forget it a short while later. It's lost in the pile of 126 open tickets. Bear with me!

(Or even better, convince your friends and co-workers to participate in an exciting open-source project which is downloaded roughly 4.000 times each month). :)

@stephanrauh stephanrauh added this to the v1.4.1 milestone Dec 10, 2018
@TheCoder4eu TheCoder4eu modified the milestones: v1.4.1, v1.5.0 Dec 31, 2018
@ghost
Copy link
Author

ghost commented Jan 1, 2019

Thanks for the candidly answer, I do respect your privacy. It's awesome what you do for the community, and if I had time, I'd also like to give you a hand on some issues. Maybe I can do so in the next months...

I do also know that pull requests can speed up solving that issue, and as soon as I can find that bug in the framework, I will offer one. Currently, you've closed 131 pull requests and have 0 open, this is a very good indication of your fantastic collaboration way. Please don't give up, you're doing great work here.

@stephanrauh
Copy link
Collaborator

Well... you've contributed several PRs yourself, let me shout a "thank you" to you, too! :)

Oh, and I wish you a Happy New Year!

@Coolius70
Copy link

Hi

Was lost again for a day till I found out, that issue still exists in 1.4.1. Was struggling with 1.3 several days as well. I did rollback to 1.2 and it works again with tags. Would be great if this bug can be fixed in the nearer future because it is blocking to upgrade to a newer version and there is a very long list of improvements in the newer version. Thanks for that as well.

@geopossachs geopossachs self-assigned this Nov 24, 2019
@geopossachs
Copy link
Collaborator

geopossachs commented May 29, 2020 •
edited
Loading

found the IE bug : Das Objekt unterstützt die Eigenschaft oder Methode "startsWith" nicht
if i open https://showcase.bootsfaces.pecer.de/BootsFacesWeb/forms/inputTextWithTags.jsf
with IE11

@ghost
Copy link
Author

ghost commented May 29, 2020 •
edited by ghost
Loading

found the IE bug : Das Objekt unterstützt die Eigenschaft oder Methode "startsWith" nicht

Great that you've found this, but my bug report bases on a firefox on debian linux. So there might be another problem.

@stephanrauh
Copy link
Collaborator

Oops. Great work nonetheless, @geopossachs! THX!

@geopossachs
Copy link
Collaborator

I'm confused - i could not found bootstrap-tagsinput v0.7.2 on the project page, after an upgrade to v0.8.0 i have damage my test-setup - There is nothing in the form upload and there is no hiden input value that changes with an input. How does this lib work? - https://bootstrap-tagsinput.github.io/bootstrap-tagsinput/examples/

@stephanrauh
Copy link
Collaborator

The current repository is here: https://github.com/stephanrauh/bootstrap-tagsinput

@geopossachs
Copy link
Collaborator

geopossachs commented Jun 2, 2020 •
edited
Loading

sounds like the same bug which was fixed by #1079

@geopossachs geopossachs linked a pull request Jun 2, 2020 that will close this issue
WIP Issues/995 #1141
Open
@geopossachs
Copy link
Collaborator

@stephanrauh in the version v0.8.0 there is no IE bug. can we use the version of the main repo or do we need the forked older version? if have found a bug with a missing css class in the newer version but i can fix this via jquery

@stephanrauh
Copy link
Collaborator

I've forked the version because the original bootstrap-tagsinput seems to be dead. So my fork should be newer than the 0.7.2 version. There's no need to use jQuery: I've forked the project specifally for BootsFaces, so you can fix bugs yourself.

@TheCoder4eu TheCoder4eu modified the milestones: v1.5.0, v1.6.0 Aug 8, 2020
@stephanrauh
Copy link
Collaborator

I'm afraid development of BootsFaces has slowed down considerably. We'll never manage to address this issue. Let's close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geopossachs geopossachs

Labels
bug confirmed wontfix
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging a pull request may close this issue.

WIP Issues/995 TheCoder4eu/BootsFaces-OSP
4 participants
@stephanrauh @TheCoder4eu @geopossachs @Coolius70