-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
b:datatable per-column filtering only returns matches in all columns #433
Comments
I currently can't seem to be able to reproduce this. The Showcase example (the second) seems to work fine. Does it work for you as well? Maybe you can provide a small example for us to reproduce. Edit: Right after submitting this, I figured you meant the |
That's a quick response! What I understood is a specific column is filtered. There is now Showcase for this on your page. They all have multi-column-search not set so basically default value false. You just need to have one row, my previous example col1: John and col2: Dow. Thanks for having a look at this. |
That's the same bug I've encountered this evening. Currently, it puzzles me. The source code we generate looks precisely as the working demo at https://datatables.net/examples/api/multi_filter.html. BTW, after your nice words about BootsFaces we simply have to solve the bug for you! :) |
I feel honoured :) |
More precisely, the search seems to match rows that have the input in every read-only cell. Input fields are ignored. |
Even worse than I thought ;) Then it's worth fixing it! |
Oh, and I just started to enjoy our nice little chat :). Anyway, I finally managed to wrap my head around it. For some reason, we registered a key listener to every input field in every column. That sounds good, but it was implemented as a double for loop, which means we've registered 25 listeners for a table consisting of five columns. Strange bug - especially because it seems to be the same source code as in the documentation. My current solution is not good, but it'll do for the moment. |
Just in case you want to test the bug fix: I've pushed a new version of BootsFaces 0.9.0-SNAPSHOT to Maven Central. See #369 on how to get it. |
To dos left:
|
I have tried working with BootsFaces 0.9.0-SNAPSHOT and Maven to be prepared when it is fixed :) |
Hey,
|
I have tried searching="true" and searching="false". |
Nasty fields :). Have a look at http://www3.bootsfaces.net/Showcase/forms/DataTable.jsf (sourcecode at https://github.com/TheCoder4eu/BootsFacesWeb/blob/master/src/main/webapp/forms/DataTable.xhtml). The second demo allows you to switch searching and multi-column-searching on. The table is reloaded on-the-fly by an AJAX request. Hope that helps! |
My genius his hiding at the moment ... I am sure it will surprise me later when I am done with digesting ;). |
OK. The values of multi-column-search I found, it says with a spelling mistake botton "'top','botton', and 'both'. Default to 'bottom'". ... and set it to something. Look my genius turned up again: |
... and it works even filtering in the specific column. My John Dow appears now. I meant to call him John Doe but I was so touched by the difficult times of Jones Dow ;) Thanks you for solving this. Shall we keep the default value for multi-column-search-position to be solved within this issue? |
Jones Dow :) |
Let's close this ticket and open a new ticket for search buttons above the table. @susanne69 THX for your help! I've deactivated the option - I hope that helps other developers avoid the trap I've let you run into. I'm going to publish another developer snapshot to Maven Central in a couple of moments. |
I've uploaded the snapshot and opened a follow-up ticket (#436). |
Hi,
I am using Bundle-Version: 0.8.6, Bundle-Date: 20160522-21:44:31.
Entering a filter value in an individual column returns only rows where the value is found in all columns per row.
Example:
firstname lastname
John Dow
If I enter 'o' it returns the row but 'dow' the row disappears.
Is this possible to fix?
Bootsfaces is great :)
The text was updated successfully, but these errors were encountered: