Skip to content
This repository has been archived by the owner on Mar 24, 2024. It is now read-only.

Regex support #22

Open
ThatsNoMoon opened this issue Sep 7, 2020 · 0 comments
Open

Regex support #22

ThatsNoMoon opened this issue Sep 7, 2020 · 0 comments
Labels
feature New feature
Projects

Comments

@ThatsNoMoon
Copy link
Contributor

ThatsNoMoon commented Sep 7, 2020

Consider using a capture group for positive matches, if the group isn't captured then the match is ignored.

My main concern with this is ensuring that users can't exploit it easily. A lot of care will have to be taken, and limitations should be put on e.g. the length of allowed regexes. Regexes will have to be cached (if regex doesn't do that already) to avoid repetitive compilation costs. Ideally some benchmarks on how fast the current text-based matching is can be compared to regex-based matching, including with very complicated regexes.

@ThatsNoMoon ThatsNoMoon added the enhancement Improvement to existing feature label Sep 7, 2020
@ThatsNoMoon ThatsNoMoon added this to Later in Work Sep 7, 2020
@ThatsNoMoon ThatsNoMoon added feature New feature and removed enhancement Improvement to existing feature labels Dec 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature
Projects
Work
  
Later
Development

No branches or pull requests

1 participant