redirect to lecture2gether room when it is entered #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timonegk
force-pushed
the
feature/enter_lecture2gether_url
branch
from
3f97c86
to
31a3c4c
Compare
This also cleans up some URL logic and closes #13
timonegk
force-pushed
the
feature/enter_lecture2gether_url
branch
from
31a3c4c
to
b7b5d8b
Compare
Flova
reviewed
Jul 19, 2020
| @@ -93,8 +93,14 @@ export default class Toolbar extends Vue { | |||
| throw new Error(`${response.status}: Resource not available`); | |||
| }); | |||
| } | |||
| // update the url to point to the lecture2go playlist when it is a | |||
| if (this.isValidVideoUrl(this.url) || this.url.includes('lecture2go') || this.url.includes('/l2go/')) { | |||
There was a problem hiding this comment.
It looks like the check if the URL contains e.g. lecture2go is missing in the new version. Or is this handled in another way?
There was a problem hiding this comment.
As I can see it; yes that check has been removed. But I don't really understand what it was supposed to do?
There was a problem hiding this comment.
I made this comment a long time ago, but I think it this check checks if the entered url is a valid one for one of our services (l2f, yt, mp4, ...) otherwise the red url bar is shown.
|
@timonegk Looks pretty good to me but you would need to rebase the commits from master so that we can merge this |
|
ping @timonegk |
|
@timonegk should I do it instead? |
|
Yes, that'd be great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also cleans up some URL logic and closes #13