Skip to content
This repository has been archived by the owner on Aug 1, 2023. It is now read-only.

[BUG] MangaSee Unexpected Behaviour #45

Open
Pooja1711agg opened this issue Nov 13, 2022 · 2 comments
Open

[BUG] MangaSee Unexpected Behaviour #45

Pooja1711agg opened this issue Nov 13, 2022 · 2 comments
Labels
bug Something isn't working nepnep Issue for the NepNep branch

Comments

@Pooja1711agg
Copy link

Pooja1711agg commented Nov 13, 2022

Describe the bug
The app takes you to Vol 2 CH 17 instead of going to Vol 2 CH 1 when you click on next chapter on Vol. 1 CH. 16 of Berserk Manga and skips 16 chapters (Vol 2 CH 1 - Vol 2 CH 16) in the process.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Vol. 1 CH. 16 of Berserk Manga (Source - Mangasee)
  2. Click on Next Chapter

Expected behavior
It should take you to the next chapter i.e. is Vol. 2 CH. 1

Screenshots/Video
video link

App version

  • v0.7-r46

Source WITH source version

  • MangaSee 2.2.0 (NepNep (Netsky Fork))

Additional context

@Pooja1711agg Pooja1711agg added the bug Something isn't working label Nov 13, 2022
@TheNetsky
Copy link
Owner

That's because iirc volumes are not being used, due to most items not having these. Can only be fixed by adding chapter parsing. Feel free to submit a PR for this.

@TheNetsky TheNetsky transferred this issue from TheNetsky/extensions-sources Nov 13, 2022
@TheNetsky TheNetsky added the nepnep Issue for the NepNep branch label Nov 13, 2022
@Ivanmatthew
Copy link
Contributor

Describe the bug The app takes you to Vol 2 CH 17 instead of going to Vol 2 CH 1 when you click on next chapter on Vol. 1 CH. 16 of Berserk Manga and skips 16 chapters (Vol 2 CH 1 - Vol 2 CH 16) in the process.

To Reproduce Steps to reproduce the behavior:

  1. Go to Vol. 1 CH. 16 of Berserk Manga (Source - Mangasee)
  2. Click on Next Chapter

Expected behavior It should take you to the next chapter i.e. is Vol. 2 CH. 1

Screenshots/Video video link

App version

  • v0.7-r46

Source WITH source version

  • MangaSee 2.2.0 (NepNep (Netsky Fork))

Additional context

Indexing the chapter numbers by [volumenumber].[chapternumber] (E.g. Volume 1 Chapter 23 internally becomes 1.23) and then sorting by that number could be a potential solution to this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working nepnep Issue for the NepNep branch
Projects
None yet
Development

No branches or pull requests

3 participants