Update variable names and cleanup README

Author: NonSwag

README.md

@@ -71,80 +71,55 @@ import net.milkbowl.vault.chat.Chat;
 import net.milkbowl.vault.economy.Economy;
 import net.milkbowl.vault.economy.EconomyResponse;
 import net.milkbowl.vault.permission.Permission;
-
 import org.bukkit.command.Command;
 import org.bukkit.command.CommandSender;
 import org.bukkit.entity.Player;
-import org.bukkit.plugin.RegisteredServiceProvider;
 import org.bukkit.plugin.java.JavaPlugin;
 
 public class ExamplePlugin extends JavaPlugin {
-    
-    private static Economy econ = null;
-    private static Permission perms = null;
+    private static Economy economy = null;
+    private static Permission permission = null;
     private static Chat chat = null;
-
-    @Override
-    public void onDisable() {
-        getLogger().info(String.format("[%s] Disabled Version %s", getDescription().getName(), getDescription().getVersion()));
-    }
-
+    
     @Override
-    public void onEnable() {
-        if (!setupEconomy() ) {
+    public void onLoad() {
+        if (getServer().getPluginManager().getPlugin("Vault") == null) {
             getLogger().severe(String.format("[%s] - Disabled due to no Vault dependency found!", getDescription().getName()));
             getServer().getPluginManager().disablePlugin(this);
-            return;
-        }
-        setupPermissions();
-        setupChat();
-    }
-    
-    private boolean setupEconomy() {
-        if (getServer().getPluginManager().getPlugin("Vault") == null) {
-            return false;
-        }
-        RegisteredServiceProvider<Economy> rsp = getServer().getServicesManager().getRegistration(Economy.class);
-        if (rsp == null) {
-            return false;
         }
-        econ = rsp.getProvider();
-        return econ != null;
     }
-    
-    private boolean setupChat() {
-        RegisteredServiceProvider<Chat> rsp = getServer().getServicesManager().getRegistration(Chat.class);
-        chat = rsp.getProvider();
-        return chat != null;
+
+    @Override
+    public void onEnable() {
+        economy = getServer().getServicesManager().load(Economy.class);
+        permission = getServer().getServicesManager().load(Permission.class);
+        chat = getServer().getServicesManager().load(Chat.class);
     }
-    
-    private boolean setupPermissions() {
-        RegisteredServiceProvider<Permission> rsp = getServer().getServicesManager().getRegistration(Permission.class);
-        perms = rsp.getProvider();
-        return perms != null;
+
+    @Override
+    public void onDisable() {
+        getLogger().info(String.format("[%s] Disabled Version %s", getDescription().getName(), getDescription().getVersion()));
     }
-    
+
     public boolean onCommand(CommandSender sender, Command command, String commandLabel, String[] args) {
-        if(!(sender instanceof Player)) {
+        if (!(sender instanceof Player player)) {
             getLogger().info("Only players are supported for this Example Plugin, but you should not do this!!!");
             return true;
         }
-        
-        Player player = (Player) sender;
-        
-        if(command.getLabel().equals("test-economy")) {
-            // Lets give the player 1.05 currency (note that SOME economic plugins require rounding!)
-            sender.sendMessage(String.format("You have %s", econ.format(econ.getBalance(player.getName()))));
-            EconomyResponse r = econ.depositPlayer(player, 1.05);
-            if(r.transactionSuccess()) {
-                sender.sendMessage(String.format("You were given %s and now have %s", econ.format(r.amount), econ.format(r.balance)));
+
+        if (command.getLabel().equals("test-economy")) {
+            // Let's give the player 1.05 currency (note that SOME economic plugins require rounding!)
+            sender.sendMessage(String.format("You have %s", economy.format(economy.getBalance(player.getName()))));
+            EconomyResponse r = economy.depositPlayer(player, 1.05);
+            if (r.transactionSuccess()) {
+                sender.sendMessage(String.format("You were given %s and now have %s", economy.format(r.amount), economy.format(r.balance)));
             } else {
-                sender.sendMessage(String.format("An error occured: %s", r.errorMessage));
+                sender.sendMessage(String.format("An error occurred: %s", r.errorMessage));
             }
             return true;
-        } else if(command.getLabel().equals("test-permission")) {
-            // Lets test if user has the node "example.plugin.awesome" to determine if they are awesome or just suck
-            if(perms.has(player, "example.plugin.awesome")) {
+        } else if (command.getLabel().equals("test-permission")) {
+            // Let's test if the user has the node "example.plugin.awesome" to determine if they are awesome or just suck
+            if (permission.has(player, "example.plugin.awesome")) {
                 sender.sendMessage("You are awesome!");
             } else {
                 sender.sendMessage("You suck!");
@@ -154,15 +129,15 @@ public class ExamplePlugin extends JavaPlugin {
             return false;
         }
     }
-    
+
     public static Economy getEconomy() {
-        return econ;
+        return economy;
     }
-    
+
     public static Permission getPermissions() {
-        return perms;
+        return permission;
     }
-    
+
     public static Chat getChat() {
         return chat;
     }