Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All courses: Remove Replit #29054

Open
3 tasks done
Eduardo06sp opened this issue Nov 6, 2024 · 25 comments
Open
3 tasks done

All courses: Remove Replit #29054

Eduardo06sp opened this issue Nov 6, 2024 · 25 comments
Assignees

Comments

@Eduardo06sp
Copy link
Member

Eduardo06sp commented Nov 6, 2024

Checks

Describe your suggestion

To put it succinctly, I have no idea what benefits we get from using Replit instead of GitHub.

I was looking for similar issues, but instead, I actually found several drawbacks to using Replit including, but not limited to:

If we agree to make this change, then I can dig deeper and get all the Replit links I can find. In the meanwhile, this is The Odin Project's Replit profile, which indicates what lessons use Replit:
https://replit.com/@OdinProject

Path

Other / NA

Lesson Url

https://www.theodinproject.com/paths

(Optional) Discord Name

Eduardo06sp

(Optional) Additional Comments

No response

@bizarf
Copy link
Contributor

bizarf commented Nov 6, 2024

I would add that the Replit repos need updating as the config files are outdated. Pressing the run button causes nothing to happen now, and the user will have to click on the shell window and type node index.js to run the code.

The four Replit repos are from this lesson:
https://www.theodinproject.com/lessons/foundations-data-types-and-conditionals

I believe the use was to allow the user to quickly try JavaScript coding by solving the short problems in the repos.

@MaoShizhong
Copy link
Contributor

@TheOdinProject/maintainers I vaguely remember a past discussion about migrating to Stackblitz for these sorts of exercises (inc. codesandboxes e.g. from the React course)?

@ccooffoo
Copy link

@Eduardo06sp Does TOP uses Replit just for the 4 exercises already mention here? when I was doing the exercises I got confused using Replit. So I suggested some changes to the content to avoid confusion but, if you guys are going to migrate, I think it's better to wait for the decision about the tool you guys are going to implement.

@Eduardo06sp
Copy link
Member Author

Eduardo06sp commented Nov 13, 2024

@ccooffoo I haven't done a thorough search, but I think that may be the case.

I need to go through the lessons and double check. I'm wondering if we can just copy them over to a GitHub repo and have the same exact functionality as before without all those drawbacks.

@XAJX179
Copy link
Contributor

XAJX179 commented Nov 13, 2024

replit has a 1200 minutes per month limit on development time https://replit.com/pricing , which has resulted in some users getting timed out in just 2 days accidentally because it would count the time even if u just leave the tab open or don't log out

replit is also mentioned in how to ask great question page and the odin bot commands in discord and in many ruby lessons too so we should remove it from there too - https://www.google.com/search?q=site:theodinproject.com+replit

@KevinMulhern
Copy link
Member

I need to go through the lessons and double check. I'm wondering if we can just copy them over to a GitHub repo and have the same exact functionality as before without all those drawbacks.

@Eduardo06sp I think you're right, we should be able to add them to the JavaScript exercises repo. All the prerequisites with using Git have been covered by the time these exercises come around. Theres no strong reasons for them to be in Repl.it as far as I can tell.

@JoshDevHub
Copy link
Contributor

@KevinMulhern @Eduardo06sp I think the exercises could be moved to the JavaScript exercises repo, but another thing will have to change to accommodate that: the position of the node install lesson, which currently doesn't happen until very late in Foundations. Without node installed, learners have no way to run JS programs locally.

I don't think that's a huge deal or anything, but it's just something to keep in mind.

@Eduardo06sp
Copy link
Member Author

@JoshDevHub A quick grep search indicates that the only place we actually have Replit exercises is for Data Types and Conditionals (https://www.theodinproject.com/lessons/foundations-data-types-and-conditionals#assignment).

Most of the rest of the mentions are scattered throughout the Ruby lessons, but we can just leave IRB as the recommendation. There are a few other places too, but without any actual exercises.

To get to my point, all we would need to do is move the Installing Node.js lesson back a little so it's right before Data Types and Conditionals, which is still in the same JavaScript Basics section (https://www.theodinproject.com/paths/foundations/courses/foundations#javascript-basics). The change honestly does not seem drastic as it would only be moved a few lessons back. I think it would still remain at the same level difficulty for users going through the curriculum.

@Eduardo06sp
Copy link
Member Author

I am now willing to work on this issue, as I'm not sure that this would be a good Issue for a first-time contributor.

If I get the green flag to proceed on this, I can produce a list of changes that need to be made, and get that approved before beginning my work on it.

@KevinMulhern
Copy link
Member

Thanks @JoshDevHub, I forgot that was a prerequisite.

I think we're good to go @Eduardo06sp!

@ccooffoo
Copy link

Changes sound interesting. In my case, after reading this text: —To get started, you will need to create a free Replit account.—I got little confused because I thought the exercises would open a .js file or folder to add in vscode and run the code.

I'll follow up on the changes.

@Eduardo06sp
Copy link
Member Author

Eduardo06sp commented Nov 15, 2024

@KevinMulhern Please assign me, and let me know if this looks good to you:

Criteria for approval:

@Eduardo06sp
Copy link
Member Author

Eduardo06sp commented Nov 15, 2024

I know @MaoShizhong mentioned perhaps sticking to another platform. I was under the impression that we could just stick to GitHub and follow the same kind of pattern that all the javascript-exercises files follow.

To elaborate on my plans, for each exercise, I can create:

  • a README that describes what to do
  • an exercise file
  • a test file
  • a solutions folder

This may be overkill, but I think it would be a lot less confusing than forcing users to go to an entirely different platform (Replit). I honestly got confused trying to navigate Replit and following the instructions a few moments ago when I tested it out.

However, I don't mean to overstep any boundaries or sidestep any discussion you guys may have held about it. I am just eager to help improve things at least a little. :}

@MaoShizhong
Copy link
Contributor

My recollection of Stackblitz stuff was only a vague one and I think was more related to codesandbox stuff from quite a while back, but wondered if there may have been a unified approach here. I like the javascript-exercises approach, though that definitely will require the Node installation lesson to be brought way forward. It would also then mean a "reminder" about the Node installation lesson ought to be added to the first lesson after the current Node installation position that has js exercises. Otherwise, anyone between the new and old Node Installation lessons would be massively caught out and miss it.

@KevinMulhern
Copy link
Member

Thanks for the breakdown Eduardo, it looks solid to me!

@Eduardo06sp
Copy link
Member Author

Eduardo06sp commented Nov 26, 2024

I am still working on this (as time permits) and will soon update the acceptance criteria comment I made above with more specific progress / PRs.

So far I have "transferred" the 4 exercises to our javascript-exercises repo along with proper README instructions. No pull request yet, but this was the part that I believe will take longest as I had to change some things.

I plan on updating that assignment portion (https://www.theodinproject.com/lessons/foundations-fundamentals-part-2#assignment) with super basic instructions to help transition users into our javascript-exercises repo.

The rest is a lot more straightforward.

KevinMulhern pushed a commit to TheOdinProject/theodinproject that referenced this issue Dec 10, 2024
<!-- Thank you for taking the time to contribute to The Odin Project. In
order to get this pull request (PR) merged in a reasonable amount of
time, you must complete this entire template. -->

## Because
<!-- Summarize the purpose or reasons for this PR, e.g. what problem it
solves or what benefit it provides. -->
we are replacing Replit exercises with ones from `javascript-exercises`,
so we need to do set up for Node.js earlier in the JavaScripts Basics
course.

## This PR
<!-- A bullet point list of one or more items describing the specific
changes. -->
* Moves the Installing Node.js lesson so it is right before the Data
Types and Conditionals lesson
- The Data Types and Conditionals lesson is where we will have new
material from `javascript-exercises`

## Issue
<!--
If this PR closes an open issue in this repo, replace the XXXXX below
with the issue number, e.g. Closes #2013.

If this PR closes an open issue in another TOP repo, replace the #XXXXX
with the URL of the issue, e.g. Closes
https://github.com/TheOdinProject/curriculum/issues/XXXXX

If this PR does not close, but is related to another issue or PR, you
can link it as above without the 'Closes' keyword, e.g. 'Related to
#2013'.
-->
Related to TheOdinProject/curriculum#29054

## Additional Information
<!-- Any other information about this PR, such as a link to a Discord
discussion. -->
Since multiple repos are affected simultaneously, it may be ideal to
merge all 3 PRs at once:

**Blockers:**
* Need to add the four new exercises to the `javascript-exercises` repo
- TheOdinProject/javascript-exercises#509
* Need to update the appropriate lessons within our `curriculum` repo to
replace the Replit lessons currently there -
TheOdinProject/curriculum#29161

I will link the relevant PRs here in a moment after I create them.

## Pull Request Requirements
<!-- Replace the whitespace between the square brackets with an 'x',
e.g. [x]. After you create the PR, they will become checkboxes that you
can click on. -->
- [x] I have thoroughly read and understand [The Odin Project
Contributing
Guide](https://github.com/TheOdinProject/theodinproject/blob/main/CONTRIBUTING.md)
- [x] The title of this PR follows the `keyword: brief description of
change` format, using one of the following keywords:
    - `Feature` - adds new or amends existing user-facing behavior
- `Chore` - changes that have no user-facing value, refactors,
dependency bumps, etc
    - `Fix` - bug fixes
-   [x] The `Because` section summarizes the reason for this PR
- [x] The `This PR` section has a bullet point list describing the
changes in this PR
- [ ] I have verified all tests and linters pass after making these
changes.
- [x] If this PR addresses an open issue, it is linked in the `Issue`
section
-   [ ] If applicable, this PR includes new or updated automated tests
@Eduardo06sp
Copy link
Member Author

@KevinMulhern Everything's ready to get checked.

I noticed that the Node.js installation lesson relocation PR was merged already, so I'll just wait for the rest of the PRs to get reviewed (see my earlier comment for an overview).

I am still left with one concern: exercise 01_helloWorld may be a bit too complex for a beginner who was just introduced to JavaScript, especially with it mentioning functions and return (they will not have been introduced to functions at this point). I did throw in a rather sparse exercise overview in one of my PRs. I was thinking of creating a new exercise (such as 00 - Preface) to create a dead simple introduction to them, but I think new users will be okay with the exercise 01_helloWorld as it is already.

I actually did the Replit exercises before transferring them over, and I found Replit (and some instructions in the exercises) to be very confusing at first, so I believe these changes are already going to be a vast improvement over having users learn a whole new platform (Replit). I was just left with that mild concern.

@ccooffoo
Copy link

I agree regarding the h01_helloWorld exercise. It is a little confuse because the instructions assume some knowledge about functions and the use of node. I was able to learn how testing the helloWorld exercise works but I had to divide the content to check step by step the concepts.

Regarding the Replit exercises, I prefer how the content is structured now. Thanks for the contribution!

@Eduardo06sp
Copy link
Member Author

@ccooffoo Thank you for your input. I was actually going to give you a heads up about these changes once I had a little more direction (since you expressed interest in following along).

What did you have to do in order to understand 01_helloWorld better? Do keep in mind that there was always the difficulty of getting used to the javascript-exercises repo in general.

Honestly, 01_helloWorld always seemed a bit too detailed. If I add an introductory lesson, I could put a lot less detail, make it easier, and have 01_helloWorld be 06_helloWorld instead, with its more "advanced" explanation.

@ccooffoo
Copy link

ccooffoo commented Dec 14, 2024

@Eduardo06sp Sure:

To understand better 01_helloWorld, I had to divide the structure of the blocks of code; I use small mind maps to associate the sub-blocks, for example the sub-blocks (describe, test, expect and .toEqual) so I can remember with more supporting information (images and behaviors); I know it sounds weird but its want I do when I first read the information that has block of code.

Then I associate the behaviors with the structure to get familiar with the pattern, and then do the exercise, and iterate if I have errors. But the mini mind maps help me to understand the code and that way I can have a clue of what to do when I have an error, or something is not going the way it should be.

By the way, the way you guys write the content of the lessons, is way better than other resources I checked. I can see the effort to keep it simple, friendly and clear.

@Eduardo06sp
Copy link
Member Author

@ccooffoo I really like that you have a system in place to help with your own learning.

However, do you think there was anything confusing about the 01_helloWorld lesson itself? Even looking at it right now, it feels like a lot to take in as an introduction.

I do agree that the lessons are very well-written, and I'm glad I haven't had to touch the lessons themselves too much. Otherwise, I could make things worse! 😁

@ccooffoo
Copy link

@Eduardo06sp As an introduction, yes, it's somewhat complex because it doesn't seem like something introductory, it's more like a part of a "testing" lesson. I was like -Is this an array/loop exercise or a node.js related topic.

The first impression to me was to print an array using 'Hello World' or something like that, not precisely to learn how to test exercises.

But I decided to take the -Ok, let's do it! Procedure haha

@Eduardo06sp
Copy link
Member Author

Eduardo06sp commented Dec 14, 2024

@ccooffoo There are 0 mentions of arrays in 01_helloWorld, so I'm not sure about that part. In addition, users at that stage will not know what an array is.

I suspect that users will be okay doing it this way, but I'll wait and see if I get the green light to create a new introductory lesson.

@ccooffoo
Copy link

ccooffoo commented Dec 14, 2024

@Eduardo06sp Oh no no, there's 0 mentions of arrays in 01_helloWorld, I'm just saying that when I checked that exercise (01_helloWorld) I didn't expect a "how to test the code", I thought it was something like printing 'Hello World!' as a string or making an array with the words, because the lesson is Arrays and Loops.

That's the reason of doing all the stuff I mentioned to master the concepts. But this is all about, to learn.

The green light you need, is for changing the introductory lesson of JS?

@Eduardo06sp
Copy link
Member Author

Eduardo06sp commented Dec 21, 2024

@ccooffoo yeah, the green light I'm waiting for is to hear what the maintainers think I should change (if anything).

I'll stand by in the meanwhile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants