Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Selectors: Add note not to do the test Skills in linked MDN article #29241

Closed
3 tasks done
danieletie opened this issue Dec 28, 2024 · 3 comments · Fixed by #29277
Closed
3 tasks done

Advanced Selectors: Add note not to do the test Skills in linked MDN article #29241

danieletie opened this issue Dec 28, 2024 · 3 comments · Fixed by #29277
Assignees

Comments

@danieletie
Copy link
Contributor

Checks

Describe your suggestion

Referring to this lesson, there's a link to an article on the MDN and at the bottom of the article is a "Test your skills!" section.

image

Is it possible to have a note that says not to do the test your skills? This is because at this point in the lesson, there are skills tested that haven't been discussed.

Maybe later on during the lesson, probably towards the end, a link like so to the Tesk Skills section of the article can be added which then tests knowledge all of the topics discussed during the lesson. This is because the skills tested are good and representetative of what is discussed in the lesson

Path

Node / JS

Lesson Url

https://www.theodinproject.com/lessons/node-path-intermediate-html-and-css-advanced-selectors

(Optional) Discord Name

daniel.scrypt

(Optional) Additional Comments

No response

@rlmoser99
Copy link
Member

Thank you for taking the time to make this issue. I believe this link would be better to be moved to the Assignment section of the lesson. We have began to move most of the links in our lesson to be during an assignment, versus sprinkled throughout the lesson.

Do you think moving that link to the Assignment section would work better?

@danieletie
Copy link
Contributor Author

danieletie commented Jan 1, 2025

Yes please. Thanks for responding. I think moving the link to the assignment section would work better.

Edit: I mean the link "Test your skills" section can be added to the assignment section. The knowledge on the rest of the MDN docs page is still beneficial to the concepts being discussed up to that point.

So we can add notes to skip the "Test your Skills" I've seen this in previous lessons.

@rlmoser99
Copy link
Member

Sounds like a good plan. I've assigned you to this issue. When you make a PR, please reference this issue in the body of the PR.

danieletie added a commit to danieletie/curriculum that referenced this issue Jan 3, 2025
- add note to 'MDN article on combinators' link not to do test your skill
  at bottom of linked MDN article for selectors
- add assignment that links to test your skills section of MDN article
  to practice lesson on selectors
danieletie added a commit to danieletie/curriculum that referenced this issue Jan 3, 2025
- add note to 'MDN article on combinators' link not to do test your skill
  at bottom of linked MDN article for selectors
- add assignment that links to test your skills section of MDN article
  to practice lesson on selectors
KevinMulhern pushed a commit that referenced this issue Jan 6, 2025
…29277)

* Update advanced selectors lesson #29241

- add note to 'MDN article on combinators' link not to do test your skill
  at bottom of linked MDN article for selectors
- add assignment that links to test your skills section of MDN article
  to practice lesson on selectors

* Update advanced selectors lesson #29241

- add note to 'MDN article on combinators' link not to do test your skill
  at bottom of linked MDN article for selectors
- add assignment that links to test your skills section of MDN article
  to practice lesson on selectors

* Correct spelling error in newly added assignment

- correct the spelling of assesment to assessment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants