-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend ++ command to award double points for good questions #176
Comments
hey @twalton83, can I work on this? |
If you can write the corresponding tests for this, absolutely. |
@timothyling1994 Will you be taking this issue? |
@twalton83 hey sorry for the delay. yes! i'll take this issue. I'll spend some time this weekend to work on it. |
Please let us know if you have any questions about the testing or DiscordJS. |
@twalton83 I took a look at the codebase and had a couple of questions:
|
In these units tests we are testing that the function itself works, not that the API is hit, so we should mock axios (see elsewhere in the test file for an example). Refer to this issue for bullet 2- no need to hit the API twice now: #175 |
@timothyling1994 Do we have any update? :D |
@twalton83 the implementation is done but still working on getting the test cases set up. will try to finish it up this week |
@twalton83 I'm still unclear on how to POST the API endpoint to add 2 points to a specific user. The issue you linked above (#175) seems to be about filtering the leaderboard data when using GET on the endpoint. I'm unclear on what parameter I need to pass in the API call to add 2 points. Let me know if I'm misinterrepting anything in that ticket. I can also hop on Discord if you wanted to chat further there. |
@KevinMulhern do you mind clarifying or perhaps pointing this user to the POST route? |
@twalton83 sorry for the delay. The post route takes a value param for the points amount, for example: |
@timothyling1994 Did the above clear this up for you? |
@twalton83 yes this cleared it up - I've made the appropriate changes. Currently reviewing merge differences between my local repo and the current upstream main branch. I should be able to submit my PR tomorrow. Apologies on the delay |
@twalton83 Created the PR above. Let me know if you have any questions or comments! |
Closed by #189 |
Description
In an effort to improve the Discord community, the ability for maintainers and core members to award 2 points for good questions should be implemented.
Acceptance Criteria
@user ?++
to award pointsDouble points for a great question! @user has XX points!
The text was updated successfully, but these errors were encountered: