Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #449

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Dev #449

wants to merge 7 commits into from

Conversation

techux
Copy link

@techux techux commented Oct 16, 2023

Solved Issue #197 #442 #124 #243

https://motherfuckingwebsite.com site is down so it always show No Internet connection available. Replaced it with https://google.com as google.com never goes down, check_intr() function works properly.

Description

NOTE: For the PR to be reviewed it is compulsory to mention the reviewed issue.
Please include a summary of the change and which issue is fixed. List any dependencies that are required for this change.

Fixes:

  • Mention issue using #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration.

Checklist:

  • This PR fixes a reviewed issue.(If not create an issue first)
  • This PR points to dev branch
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings

0n1cOn3 and others added 7 commits August 6, 2021 06:30
 * As the Windows Subsystem we were receiving two distro variants from that, so just head it at 1

Signed-off-by: mohdamaan570 <[email protected]>
Fix up issue in Windows Subsystem
Updated Internet Availability Check Logic
Co-authored-by: SpeedX <[email protected]>
Copy link
Contributor

@0n1cOn3 0n1cOn3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For certain people, Google doesnt work (eg. China). Due that, we've decided this specific website due its major not being blocked anywhere on the world.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants