Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support OneOf Validation with FieldMasks #4

Open
KrishnaIyer opened this issue Jan 29, 2019 · 0 comments
Open

Support OneOf Validation with FieldMasks #4

KrishnaIyer opened this issue Jan 29, 2019 · 0 comments
Assignees
@KrishnaIyer

Comments

@KrishnaIyer
Copy link

Summary:

Protobuf OneOf messages are to be validated based on the fieldmask provided.

Why do we need this?

Since we use oneof messages in the codebase.

What is already there? What do you see now?

No support for OneOfs with fieldmasks.

What is missing? What do you want to see?

Support OneOfs with fieldmasks.

How do you propose to implement this?

Modify the existing util function to inject fields specific to the actually defined message.

What can you do yourself and what do you need help with?

I can create a PR.
@KrishnaIyer KrishnaIyer self-assigned this Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KrishnaIyer KrishnaIyer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KrishnaIyer