Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the API fields data type information in the API documentation #1101

Open
ymgupta opened this issue May 15, 2023 · 5 comments
Open

Improve the API fields data type information in the API documentation #1101

ymgupta opened this issue May 15, 2023 · 5 comments
Assignees
Milestone

Comments

@ymgupta
Copy link
Collaborator

ymgupta commented May 15, 2023

Summary

The Things Stack users are often confused with API field data types i.e., in the documentation API field type type: bytes does not imply base64. Also, the type of API field interpreted should depends on the actual message. For example, the frm_payload of the ApplicationDownlink is read as a base64 type, whereas the dev_eui field of the EndDeviceIdentifiers is read as hex.

Why do we need this ?

To help users in distinguishing between different data types of API fields.

What is already there? What do you see now?

https://www.thethingsindustries.com/docs/reference/api/

What is missing? What do you want to see?

API fields with more details on the data types/examples.
@adriansmares , could you please add your insights here?

How do you propose to document this?

...

Can you do this yourself and submit a Pull Request?

No, @nejraselimovic

@github-actions github-actions bot added the needs/triage We still need to triage this label May 15, 2023
@adriansmares
Copy link
Contributor

We need to update our tooling in order to deal with this inconsistency. I will pick this up.

@adriansmares adriansmares self-assigned this May 15, 2023
@NicolasMrad NicolasMrad added this to the 2023 Q2 milestone May 16, 2023
@NicolasMrad NicolasMrad removed the needs/triage We still need to triage this label May 16, 2023
@KrishnaIyer KrishnaIyer modified the milestones: 2023 Q2, Oct 2023 Oct 1, 2023
@KrishnaIyer
Copy link
Contributor

@adriansmares: It would be great if you could find some time to pick this up this month.

@KrishnaIyer KrishnaIyer modified the milestones: Oct 2023, Dec 2023 Dec 5, 2023
@KrishnaIyer
Copy link
Contributor

I'll pick this up as part of the API documentation item that I'm working on.

@KrishnaIyer KrishnaIyer modified the milestones: Dec 2023, 2024 Q1 Jan 26, 2024
@nejraselimovic
Copy link
Contributor

hey @KrishnaIyer was this covered in #1230?

@KrishnaIyer
Copy link
Contributor

I think this requires a few small updates to the generated docs. I'll pick this up later this month.

@KrishnaIyer KrishnaIyer modified the milestones: 2024 Q1, Backlog Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants