Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Introduce Blynk integration #1375

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

doc: Introduce Blynk integration #1375

wants to merge 5 commits into from

Conversation

Munoon
Copy link

@Munoon Munoon commented Sep 4, 2024 •
edited
Loading

Summary

Resolves #1374

Screenshots

Снимок экрана 2024-09-04 в 13 11 05
Снимок экрана 2024-09-04 в 13 11 09
Снимок экрана 2024-09-04 в 13 11 15

Changes

Introduces three new pages:

  • Blynk
  • Blynk -> Getting started
  • Blynk -> Automated Device Onboarding
  • Blynk -> Device Grouping

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Run Locally: Verified that the docs build using make server, posted screenshots, verified external links. Test with HUGO_PARAMS_SEARCH_ENABLED=true if style changes will affect the search bar.
  • New Features Marked: Documentation for new features is marked using the new-in-version shortcode, according to the guidelines in CONTRIBUTING.
  • Style Guidelines: Documentation obeys style guidelines in CONTRIBUTING.
  • Commits: Commit messages follow guidelines in CONTRIBUTING, there are no fixup commits left.

vlasebian
vlasebian reviewed Dec 12, 2024
View reviewed changes
Copy link
Contributor

@vlasebian vlasebian left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, left a few comments which are just some nit picks. There is one issue I see here, the interface of Blynk uses the 'The Things Network' name (which is the name of the community) instead of 'The Things Stack' which is the actual name of the product. Also the logo used in Blynk for the integration should be the one from The Things Stack, not The Things Network. Would it be possible to change that?

doc/content/integrations/cloud-integrations/blynk/_index.md Outdated Show resolved Hide resolved
doc/content/integrations/cloud-integrations/blynk/automated-device-onboarding.md Outdated Show resolved Hide resolved
doc/content/integrations/cloud-integrations/blynk/automated-device-onboarding.md Outdated Show resolved Hide resolved
doc/content/integrations/cloud-integrations/blynk/getting-started.md Outdated Show resolved Hide resolved
@Munoon
Copy link
Author

Munoon commented Dec 12, 2024

Looks really good, left a few comments which are just some nit picks. There is one issue I see here, the interface of Blynk uses the 'The Things Network' name (which is the name of the community) instead of 'The Things Stack' which is the actual name of the product. Also the logo used in Blynk for the integration should be the one from The Things Stack, not The Things network. Would it be possible to change that?

Thank you. Yeah, we've already updated the naming some time ago, I will update the screenshots. Thank you.

@Munoon Munoon requested a review from vlasebian December 16, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nejraselimovic nejraselimovic Awaiting requested review from nejraselimovic

@KrishnaIyer KrishnaIyer Awaiting requested review from KrishnaIyer KrishnaIyer is a code owner

@vlasebian vlasebian Awaiting requested review from vlasebian vlasebian is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce Blynk documentation
2 participants
@Munoon @vlasebian