Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fieldmask.enable option to protos #5

Open
rvolosatovs opened this issue Nov 19, 2018 · 4 comments
Open

Add fieldmask.enable option to protos #5

rvolosatovs opened this issue Nov 19, 2018 · 4 comments

Comments

@rvolosatovs
Copy link
Contributor

Summary:

Plugin should consider fieldmask.enable option(true by default) and do not generate utilities for protos with fieldmask.enable = false

What is already there? What do you see now?

No option

What is missing? What do you want to see?

Option

How do you propose implementing this?

Parse the option and evaluate
@rvolosatovs rvolosatovs self-assigned this Nov 19, 2018
@htdvisser htdvisser added this to the Backlog milestone Feb 26, 2019
@sysulq
Copy link
Contributor

sysulq commented Feb 17, 2020

we need this option, and default to false is preferred...

@rvolosatovs
Copy link
Contributor Author

@hnlq715 would you be interested in contributing to this?

@sysulq
Copy link
Contributor

sysulq commented Feb 28, 2020

I wanna to try this, but I have no time recently...

@hypnoglow
Copy link

I started prototyping the solution for this issue, hope to submit a draft soon.

@htdvisser htdvisser removed this from the Backlog milestone Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@htdvisser @sysulq @hypnoglow @rvolosatovs