Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalized schema : light intensity and uv index #862

Open
colinsurprenant opened this issue Dec 17, 2024 · 0 comments
Open

Normalized schema : light intensity and uv index #862

colinsurprenant opened this issue Dec 17, 2024 · 0 comments
Labels
needs/triage We still need to triage this

Comments

@colinsurprenant
Copy link

Related to #395

Summary

In /pull/524 the lightIntensity has been added under the air object.

Would it make more sense to have a separate light object which holds lightIntensity and where we could also add the uvIndex field also found in the SenseCAP S2120 per the discussion in https://www.thethingsnetwork.org/forum/t/sensecap-s2120-8-in-1-payload-edit/62487

Why do we need this?

  • I am not sure I understand why light related metrics are under the air object?
  • Also adding uvIndex would provide support for the SenseCAP 2120 UV and Light Intensity sensor.

Can you do this yourself and submit a Pull Request?

Yes.

I can submit a PR for the air object idea or just submit a PR for the addition of uvIndex under air depending on the outcome of the discussion here.

@github-actions github-actions bot added the needs/triage We still need to triage this label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/triage We still need to triage this
Projects
None yet
Development

No branches or pull requests

1 participant