-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FlatList Support #2668
Comments
It seems to be specific to Android, but would be good to get confirmation on that. |
Thanks for opening this 'master ticket', i am wondering if someone tryed to change surfaceview / textureview props ? https://github.com/react-native-video/react-native-video#usetextureview |
I think many other multiple issues are connected to exoplayer being outdated, I have not faced much issue with IOS but its a mess in android. I am using it with flipkart's recycler list view.
|
@swikars1 we have a VIP PR to upgrade to the latest version. We need help with getting it finished. |
This worked for me: |
@hueniverse I wish I could help man, I'm from Javascript world and everything here seems so alien to me. |
@hueniverse #2667 issue appears on ios too. I spent a lot of time investigating this issue, and I found, that the iOS AV pipeline will be full and can't detach from the memory, and if the app creates too many player instances then won't mount any new videos. |
For me following implementation working fine for flatlist. I don't find any issue so for https://gist.github.com/rahulpandey/b7c8a6964d753bd482daea153341b465.
|
Hi @hueniverse, Just asking, what do you think, by when this issue will be resolved? 🙂 |
@siddharth-kt No clue. No one has offered to work on this. |
🙁 Sad to hear that, I wanted to contribute but can't due to no knowledge in native. |
I don't have the flatlist issue rendering black in alpha 3 but the videos are choppy, the playback is long to start, it seems like the videos are not buffering properly |
found any solution yet? |
@hueniverse playing multiple videos at once is a hardware limitation, thats why youtube also preview one video at a time when in focus. To give better experience one can show thumbnail where video paused and resume from there by remounting video component. If still facing avc decoder failure then replace ReactExoplayerViewManager dropViewManager instance with // ReactExoplayerViewManager.java
@Override
public void onDropViewInstance(ReactExoplayerView view) {
view.release();
} then define release() method inside ReactExoplayerView.java // ReactExoplayerView.java
public void release() {
player.release()
} |
This package works better than FlatList but its not perfect |
same issue here my report is #3251 (comment) please tell me how can I solved it some time not play video and also check alpha version |
@wolfxpertlab setup a meet for [email protected], maybe I can help 🙂 |
any solution?? crash my app <FlatList
|
For people how stuck on decoder error, Can you try following patch: #3416 |
To be retested on beta.6 |
Any solution? |
@vishalhyperspace which version are you using? @freeboub said v6.0.0-beta.6 should fix this issue (though you could install the latest version to date which is v6.0.0-rc.0 |
@avencat I'm having the same problem as @vishalhyperspace |
@longphi97 on which version? |
@avencat version 6.1.2 |
Ok @freeboub do you think @longphi97 should open a new issue with more information? |
In the meantime, @longphi97 maybe you should try to open a snack where you reproduce this error! 😉 |
Is there any update on the blank screen thing in android? I'm using the latest version v6.8.1 Still getting the blank screen in flatlist on scroll. |
Same here, use the latest version, still get the blank screen if the video is under the flatlist, and is not in the current viewport while scrolling |
This issue consolidates multiple reports of problems with rendering multiple videos in a FlatList: #908, #2667, #2414, #2325,
#1636, #1318, #433, #2247
The text was updated successfully, but these errors were encountered: