Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Privacy Manifest for Promises SDK #3548

Closed
LydGol90 opened this issue Feb 27, 2024 · 18 comments
Closed

[Feature]: Privacy Manifest for Promises SDK #3548

LydGol90 opened this issue Feb 27, 2024 · 18 comments
Assignees
Labels
feature not an issue Issue is not linked to react-native-video itself

Comments

@LydGol90
Copy link

Description

Hi there,

This lib makes use of Promises SDK which is on the list of Apple's "Privacy Impacting SDKs" that require a manifest and signing by Spring 2024.

The Promises SDK has now implemented a Privacy Manifest in their latest version 2.4.0 (not yet released).
https://developer.apple.com/support/third-party-SDK-requirements/
google/promises#226

Will it be possible for this lib to update to use 2.4.0 as soon as it is released so that apps using this lib can comply with Apple policy rules? This may have already been on your radar but just wanted to check!

Many thanks,
Lydia

Why it is needed ?

For Apple Privacy compliance for all apps using this lib

Possible implementation

No response

Code sample

No response

@KrzysztofMoch
Copy link
Member

Hey @LydGol90,
I have this on my mind - I am also waiting for it because, it will include support for visionOS (google/promises#224)

@KrzysztofMoch KrzysztofMoch added the not an issue Issue is not linked to react-native-video itself label Feb 28, 2024
@freeboub
Copy link
Collaborator

@KrzysztofMoch can we close this issue, or must we remove PromiseSwift dependency ?

@KrzysztofMoch
Copy link
Member

We can close this once we remove this dependency

@tdraper-dev
Copy link

@KrzysztofMoch
It seems like that dependency has been removed -> #3631

Are there any plans to release a new version w/ this change, given Apple's Privacy Manifest requirement is set to start in about 2 weeks?

@KrzysztofMoch
Copy link
Member

Yes, I think we can make release this or at start of next week
I will also look if we need manifest for our library

@mayur-bhandari
Copy link

Hi,

This library uses Spotify Persistent Cache which has a Privacy Manifest file of it's own. So if i use this library in my own React Native library which used by others via NPM, do i have to include the Privacy Manifest from Spotify? Or will this library include the Privacy Manifest? What if i use this libraries code as a custom Native Module, do i then have to specify it in my Privacy Manifest or will Apple traverse through the dependencies and find the Privacy Manifest which is added by Spotify Persistent Cache?

@aliza-khu
Copy link

Yes, I think we can make release this or at start of next week I will also look if we need manifest for our library

@KrzysztofMoch, Any Update?

@tdraper-dev
Copy link

@KrzysztofMoch

Bumping aliza's question? Any hopes of getting this cut this week, since the Apple May 1st deadline is around the corner? Thanks so much for all your efforts!

@KrzysztofMoch
Copy link
Member

Yes! I will do it tonight/tomorrow

@mayur-bhandari
Copy link

@KrzysztofMoch Since this library uses Spotify Persistent Cache, they need to add their Privacy Manifest but it looks like they have stopped uploading new versions on Pods.

@KrzysztofMoch
Copy link
Member

I saw this, but it's optional when you use cache video (disabled by default) and even if you use it you can copy manifest from them

@freeboub
Copy link
Collaborator

I saw this, but it's optional when you use cache video (disabled by default) and even if you use it you can copy manifest from them

I agree this can be an app responsibility!
Not sure on how manifest merging works, but adding some notes on how to integrate it in doc can be enough (with a link to manifest from Spotify)

@KrzysztofMoch
Copy link
Member

Sure, will add it

@KrzysztofMoch KrzysztofMoch self-assigned this Apr 22, 2024
@mayur-bhandari
Copy link

@freeboub There's no information on how the manifests are merged in the app bundle so there are a lot of questions. I guess adding manifests in sample app will resolve the issue.

@aliza-khu
Copy link

Yes! I will do it tonight/tomorrow

@KrzysztofMoch, It's 3 weeks spent. Still no update.

@freeboub
Copy link
Collaborator

Privacy manifest is automatically added when upgrading react native version.
I did the update in the sample here: #3776
@KrzysztofMoch any idea why this is not compiling ?

@KrzysztofMoch
Copy link
Member

KrzysztofMoch commented May 17, 2024

@freeboub Yes - as always when we upgrading react-native Pods are taken from cache and install is failing - I will do fix for it (somehow not sure how yet)
Workaround is to remove all cache from actions (I will do it and re-run fixed and merged)

@freeboub
Copy link
Collaborator

I think we can close this topic. let me know if I need to reopen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature not an issue Issue is not linked to react-native-video itself
Projects
None yet
Development

No branches or pull requests

6 participants