Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: IMA SDK crash #3904

Closed
Ibad9 opened this issue Jun 12, 2024 · 5 comments
Closed

[BUG]: IMA SDK crash #3904

Ibad9 opened this issue Jun 12, 2024 · 5 comments

Comments

@Ibad9
Copy link

Ibad9 commented Jun 12, 2024

Version

6.2.0

What platforms are you having the problem on?

iOS

System Version

IOS

On what device are you experiencing the issue?

Real device, Simulator

Architecture

Old architecture

What happened?

I navigated to my video player page and navigated back before the video started playing. It crashes the app on the below lines in RCTVideo.swift

Screenshot 2024-06-13 at 1 42 41 AM

The error is related to it starts loading ad and the player is not there.

On version 6.0.0 the same behaviour don't crash my app but it starts playing audio on other screen when I navigate back.

Reproduction

repository link

Reproduction

Step to reproduce this bug are:

Navigate to video player page having preroll ads navigate back immediately.

@Ibad9 Ibad9 added the bug label Jun 12, 2024
@freeboub
Copy link
Collaborator

freeboub commented Jun 14, 2024

That is very strange ... can you please provide the callstack of the crash ?
I don't see good reason for a crash here.
Additionally, a quick and dirty patch could be to wrap this call in a try / catch, but I am afraid:

  • sometimes ads don't display
  • what wil be the side effects afteraward

@Ibad9
Copy link
Author

Ibad9 commented Jun 14, 2024

Screenshot 2024-06-14 at 5 10 09 PM

I am getting this.

@freeboub
Copy link
Collaborator

OK, thank you for the screenshot, it is clean to me now. Can you please try to re test your issue with this PR: #3911 ?

@freeboub
Copy link
Collaborator

Fix will be included in 6.3.0

@Ibad9
Copy link
Author

Ibad9 commented Jun 20, 2024

This fixes the crash issue but when I navigate to video page my ad is played even if i navigate back. The player is somehow not removed or cleared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants