Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add support for visionOS full screen resize on immersive spaces #4285

Open
j6alvarez opened this issue Nov 12, 2024 · 6 comments
Open
Labels

Comments

@j6alvarez
Copy link

Description

I am developing a react-native-visionos app and using the immersive space I cannot resize the screen while on immersive mode. This seems possible on native environment on other apps.

Here is a screenshot of the app on immersive mode and fullscreen:
image

And here is a screenshot of the app on fullscreen without an immersive space:
image

Why it is needed ?

The resize and movement of the screen would be a nice feature for the videoplayer to have.

Possible implementation

I have look into some documentation and I am not certain but I think what would be needed is to implement the use of AVPlayerViewController in the RCTVideo.swift file for visionOS. According to documentation this AVPlayerViewController is the one that gets on the DockingRegionComponent being unable to move it or resize it. Seems that per default the videoplayer is being placed on this section and we have no way to edit this.

Here are other resources:

Code sample

Code sample

Copy link

Thank you for your feature request. We will review it and get back to you if we need more information.

@KrzysztofMoch
Copy link
Member

Hey @j6alvarez, It seems we cannot resize fullscreen videos with react-native-video. It's probably possible with SwiftUI using RealityKit or SceneKit, but we probably can't do it within library.

@j6alvarez
Copy link
Author

Hello @KrzysztofMoch , thanks for the answer! I see what you mean. But do you have an idea of how it is possible to do when you are not on an immersive space to resize? In the example, I can resize the fullscreen video (second screenshot). What I am asking is to be able to have the behavior of the player without an immersive space (second screenshot) inside an immersive space (first screenshot) to be able to resize and move it in the immersive space.

@moskalakamil
Copy link
Member

Hey @j6alvarez, do you still have this chalange? Did something changed?

@j6alvarez
Copy link
Author

Hello @moskalakamil, the situation has not changed. We have this issue in backlog since it's not a priority for now. But it stills being an issue. I'll be happy to provide more context if needed. I think this would be a nice feature to have for react-native-video in visionOS

@moskalakamil
Copy link
Member

moskalakamil commented Dec 17, 2024

I get it @j6alvarez, I completely agree. Personally, I haven’t delved into the topic, but as @KrzysztofMoch mentioned, there is a possibility that it can’t be done in the library and it's not currently on the roadmap. However, if this is very valuable for you, please reach out to us ([email protected]) – we could investigate the matter further and offer commercial support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants