Bug: Deployment file has `DRY_RUN_ADDRESS` as deployer — contracts may not be deployed

[gboigwe]

Description

The deployments/deployed-testnet.json file records "deployer": "DRY_RUN_ADDRESS" instead of an actual Stellar address:

{
  "network": "testnet",
  "deployer": "DRY_RUN_ADDRESS",
  "contracts": {
    "campaign-orchestrator": "CDXF...",
    "escrow-vault": "CCAB...",
    ...
  }
}

Impact

• Cannot verify who deployed the contracts — no audit trail
• Indicates contracts may have been deployed via dry-run and the deployment record wasn't updated
• The scripts/deploy.sh script likely has a flag issue where --dry-run sets this placeholder
• If contracts were actually deployed, the deployer address is lost
• If contracts were NOT actually deployed (just dry-run), the contract addresses in the file may be invalid

Suggested Fix

1. Re-deploy contracts with the actual deployer identity and update the file
2. Fix scripts/deploy.sh to not write deployment records during dry-run:

if [ "$DRY_RUN" = true ]; then
  echo "Dry run complete — skipping deployment record"
  exit 0
fi

3. Add validation in the deploy script to reject DRY_RUN_ADDRESS as a deployer

File

deployments/deployed-testnet.json — Line 3