Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Delete Group success as Owner" test #105

Open
HabuTheTiger opened this issue Oct 30, 2024 · 1 comment · May be fixed by #109
Open

Fix "Delete Group success as Owner" test #105

HabuTheTiger opened this issue Oct 30, 2024 · 1 comment · May be fixed by #109
Assignees
@HabuTheTiger
Labels
bug Something isn't working

Comments

@HabuTheTiger
Copy link
Collaborator

Currently on the main branch the "Delete Group success as Owner" (tests/Feature/Api/v1/GroupsTest.php) feature test fails. This should be fixed.

See failed job: https://github.com/Thiritin/identity/actions/runs/11601859117/job/32305547237
@HabuTheTiger HabuTheTiger added the bug Something isn't working label Oct 30, 2024
@HabuTheTiger
Copy link
Collaborator Author

After discussion, it appears that owners of groups should only be able to delete groups with the team type. So the test should reflect this change.

@HabuTheTiger HabuTheTiger self-assigned this Nov 20, 2024
@HabuTheTiger HabuTheTiger linked a pull request Nov 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HabuTheTiger HabuTheTiger

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

105 bugfix delete group success as owner test Thiritin/identity
1 participant
@HabuTheTiger