Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound only works on linux build #662

Closed
vpelss opened this issue Jan 10, 2025 · 4 comments
Closed

Sound only works on linux build #662

vpelss opened this issue Jan 10, 2025 · 4 comments
Labels

Comments

@vpelss
Copy link

vpelss commented Jan 10, 2025

For myself, I can only get sound on my windows 10 pc if I build from source using WSL.
Although The Nav/Weapon/Power/etc icons do not show when I do this build.

The newest Win 1.0.0-alpha.16 download does not produce sound.
https://github.com/Thorium-Sim/thorium-nova/releases/download/v1.0.0-alpha.16/Thorium-Nova-1.0.0-alpha.16-win.zip

When I try to build in windows it self, it builds, but still no sound.

I can only assume something in linux is required to generate sound.

I have not built on a pure linux environment yet, but I am going to assume the sound would work.

I was trying to investigate further, but not sure how sound is generated. I can't seem to see any audio files.

@vpelss vpelss added the Bug label Jan 10, 2025
@alexanderson1993
Copy link
Member

This is to be expected,
Since sound hasn't been released in an alpha yet. It's just in the main branch.

I don't know why sound isn't working on windows yet. I'll debug it before cutting a release.

@vpelss
Copy link
Author

vpelss commented Jan 10, 2025

Thanks for the info. I love the idea of a server based bridge sim that should be able to run clients on anything with a browser.

@vpelss
Copy link
Author

vpelss commented Jan 12, 2025

Update:

I have been able to build the Develop Branch on Windows (NOT wsl) using PowerShell and it DOES have sound.

Note:
PowerShell (Admin) causes the following error:

[client] 6:03:07 PM [vite] Internal server error: Cannot find module '@thorium/ui/AlertDialog' imported from 'C:/Users/vpels/thorium3/client/app/context/AppContext.tsx'

and I suspect dos cmd prompt does something similar. I believe it is less verbose with it errors. As I am not fluent with node.js, I am assuming the dos cmd prompt is a no no.

To clarify. If building on windows for windows use Powershell, but not the admin version.

@vpelss
Copy link
Author

vpelss commented Jan 12, 2025

Issue was a me thing.

@vpelss vpelss closed this as completed Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants