Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow initializing schema for Tx #27

Open
m110 opened this issue Jan 4, 2023 · 0 comments
Open

Don't allow initializing schema for Tx #27

m110 opened this issue Jan 4, 2023 · 0 comments

Comments

@m110
Copy link
Member

m110 commented Jan 4, 2023

Similar to how watermill does it: https://github.com/ThreeDotsLabs/watermill-sql/blob/bc0272d92e9475871a52182dc341db4483e22dbb/pkg/sql/publisher.go#L67

If a transaction is passed to eventstore.SQL, it should return an error when initializing the schema. Otherwise, the transaction might be implicitly committed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@m110