Replies: 4 comments 5 replies
-
The current mechanism, how we handle the TW CLA works well. IMO there is no need to change a working system. |
Beta Was this translation helpful? Give feedback.
-
Thanks @linonetwo – the docs do not seem to be in English, could you briefly outline the features and advantages? @pmario – the CLA-related enhancement that would make a big difference to me is to have a bot that automatically checks whether the author of a PR has signed the CLA, and leaves a helpful message if not. |
Beta Was this translation helpful? Give feedback.
-
There seems to be a GitHub action, that looks interesting: https://github.com/contributor-assistant/github-action and it does not need a 3rd-party that stores our data. |
Beta Was this translation helpful? Give feedback.
-
I did have a closer look at the GitHub Action Contributor-Assistant which I call bot in this comment. The workflow is interesting and it seems, it would almost work for our needs. -- But -- The project seems to be not well maintained. So we would add a dependency, that we have to maintain on our own, with way more code than what we need. The workflow is as follows (as far as I do understand it till now)
My ConclusionsWe do store our contributor signatures directly with the CLA. So there is no doubt or confusion for the contributor what they sign. There signature is right below the document they signed. The message I have read the CLA Document and I hereby sign the CLA imo says nothing. Many users will just copy/paste the text and add it to a PR comment without ever even "skim" the document they sign. I think that's a big advantage for our current workflow. We already have some code, that will allow us to check if a user did sign our current CLA. It is exceptionally simple. TW5-docs-pr-maker @saqimtiaz uses a startup http request to read the "raw" file from: Our workflow could look like this:
With that in place IMO we would be good to go.
I think, the code of the bot will be significantly simpler than the one used by CLA-Assistant, which needs a ton of dependencies to do things, we do not really need. just my thoughts |
Beta Was this translation helpful? Give feedback.
-
https://cla-assistant.io
I found https://github.com/nacos-group/r-nacos is using this, it is very smooth. @Jermolene
Beta Was this translation helpful? Give feedback.
All reactions