Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected deletion when replacing a draft tiddler #448

Open
Skeeve opened this issue Feb 27, 2014 · 2 comments
Open

Unexpected deletion when replacing a draft tiddler #448

Skeeve opened this issue Feb 27, 2014 · 2 comments

Comments

@Skeeve
Copy link
Contributor

Skeeve commented Feb 27, 2014

Try this with 5.0.7:
a) Create a tiddler "first version" with some text
b) Open it for editing
c) Change the name to "first version 1" BUT DO NOT SAVE
d) Create a new tiddler with some text and
e) give it the name "first version"
f) In the popup confirm that you want to overwrite
g) Note that the new "first version" is there
h) Save "first version 1"
i) Note that "first version" is now gone

@pmario
Copy link
Member

pmario commented Feb 27, 2014

Oh .... cool, it needed only 400 issues to pop up :)
I think this is related to #44 and may be #45.

@Jermolene
Copy link
Member

Ha! @pmario gets the prize.

I think I can see a way that this could be fixed. When the tiddler is being edited in (c) it has a prospective title of "first version". Saving the second tiddler at (f) overwrites that prospective tiddler. Saving the original tiddler at (h) deletes the original prospective tiddler in the process of handling the rename.

The draft tiddler needs to keep track of the changecount associated with the original prospective tiddler. It could then only delete the prospective tiddler if it has not been modified since the draft was created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants