Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with tag colors in Tagmanager #643

Open
gernert opened this issue Jun 10, 2014 · 8 comments
Open

Issues with tag colors in Tagmanager #643

gernert opened this issue Jun 10, 2014 · 8 comments

Comments

@gernert
Copy link
Contributor

gernert commented Jun 10, 2014

Regarding:

There are still some issues with the colors (and hexadecimal values) in the Tag manager:

  1. The default yellow/brown tag color shows black in the color picker
  2. The default yellow/brown tag color has no hexadecimal value
  3. Three digit hexadecimal color values show black in the color picker
  4. Six digit hexadecimal color values are shown correctly in the color picker

Above checked with TW 5.0.12-beta, Firefox v29.01, and Chrome v35.0.1916.114 m on Windows 7 64-bit.

@twMat
Copy link
Contributor

twMat commented Jan 28, 2016

[Still] confirming this

New laptop (and new OS) the problems still persist. Win10, FF & Chrome

tagmanager

@tobibeer
Copy link
Contributor

As for this issue, I think it's safe to say that it can be closed, since all these issues are browser issues that leave nothing actionable on the TiddlyWiki end, e.g. the browser's color picker being able to handle:

  • named colors
  • 3 digit shorthand hex values

I'd encourage you to post a feature request / leave a comment at one such at your favorite browser's repo while pointing here, maybe.

@twMat
Copy link
Contributor

twMat commented Jan 28, 2016

all these issues are browser issues

I didn't realize this. Particularly since the problem (in at least my case) is both in FF and Chrome, and for years and years. Are you sure?

@tobibeer
Copy link
Contributor

Not 100% sure, but I'd give it a 95%. ;-)

@ssokolow
Copy link

While I agree that the browsers' colour pickers should accept any valid CSS colour identifier, couldn't TiddlyWiki provide a workaround using getComputedStyle to force named colours and three-digit hex colours to be converted to something consistent, then manually parsing the rgba(...) value and re-serializing as an #RRGGBB value?

...or, at the very least, provide some kind of indication that the picker isn't actually showing the computed value of references like <<colour background>>. (eg. a yellow warning triangle in the right end of the hex field with a "This value will not be displayed by the browser's colour picker" tooltip)

@tobibeer
Copy link
Contributor

@ssokolow, right, haven't thought of that... sounds like an option worth exploring. I think we all agree that we don't want any dictionaries of named colors.

So, we can possibly fill the gaps browsers might still be leaving.

@pmario
Copy link
Member

pmario commented Jan 29, 2016

I think, there is a problem. ... The tag manager doesn't initialize the color selector box. So they are all black. And that's what the picker shows. ...

@ssokolow
Copy link

@pmario
I can't speak for whatever browser you're using, but the pickers get set up properly for Firefox on any field containing a value of the form #RRGGBB. The problem is that, to the best of my knowledge, no other format is required to be supported by the standard and some of the fields contain other things like #fff or rgba(0,200,0,0.7) or inherit or <<colour foreground>>.

That's why I suggested using getComputedStyle to resolve it to an rgba(...) value and then manually parsing and re-serializing that into an #RRGGBB format that could be fed into the picker. (Since, even if it would discard information to actually change a value like inherit or a value with an alpha component using the picker, the button makes a good preview for what the current value resolves to and, if nothing else, that makes it easier for people to internalize how the names of the fields correspond to what they actually see in the UI.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants