Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DarkModePlugin toggle button to site #314

Open
markkerrigan opened this issue Dec 19, 2024 · 1 comment
Open

Add DarkModePlugin toggle button to site #314

markkerrigan opened this issue Dec 19, 2024 · 1 comment

Comments

@markkerrigan
Copy link
Contributor

I looked and I don't see the button to toggle it on and off. Maybe adding the following in MainMenu would be the most logical?

<<darkMode label:"☀️/🌘">>
@YakovL
Copy link
Contributor

YakovL commented Dec 27, 2024

Hi Mark, I've thought about this a bit, and while I think it would be nice to have a switch, it's better to make it look nice first. I've already updated the plugin with a custom class for the button, so now it's possible to make it use just one icon (depending on the current mode: 🌘 in the light mode and ☀️ in the dark mode), the other thing I'd like to implement is to avoid it taking an extra line in a menu. I'm thinking about placing it in the same line as "options »", but it's stil a bit ugly when I put it "as is", both due to the distances and to the hover differences (ok, not very visible on screenshots, but my current capturing app got gif recording broken):

image
image
image

I'll think more about it, but if you have a suggestion about where/how to place the button, please let me know.

PS Yeah, in fact, the search UI also needs improvement (why 2 lines? why button before the input? paddings are not nice, ...)

image

Checking some references...

image
image

I think I'll work on it, too. I've added already a "label" param to the <<search>> macro for the next version (i.e. button label), can now use 🔎 for it, but there's much work left...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants