Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight difference in joining could be made clearer in the docs #55

Open
ymer opened this issue Oct 8, 2023 · 1 comment
Open

Slight difference in joining could be made clearer in the docs #55

ymer opened this issue Oct 8, 2023 · 1 comment

Comments

@ymer
Copy link

ymer commented Oct 8, 2023

In Tidyverse, join works like this:

inner_join(df1, df2, "id")

or like this:

inner_join(df1, df2, by = "id")

but not like this:

inner_join(df1, df2, by = id)

In Tidier, join works like this:

@inner_join(df1, df2, a)

or like this:

@inner_join(df1, df2, "a")

But not like this:

@inner_join(df1, df2, by = "a")
@inner_join(df1, df2, by = a)

It also does not work like this:
@inner_join(df1, df2, :a)

There could be examples in the docs showing this.

@kdpsingh
Copy link
Member

kdpsingh commented Oct 8, 2023

Great point. We can clarify the docs for now and potentially fix in the future to make it work either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants