Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scale_fill #80

Open
5 tasks
Tracked by #73
rdboyes opened this issue Apr 15, 2024 · 0 comments
Open
5 tasks
Tracked by #73

scale_fill #80

rdboyes opened this issue Apr 15, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@rdboyes
Copy link
Member

rdboyes commented Apr 15, 2024

Scale_colo[u]r is implemented, but not scale_fill. The challenge here is that Makie and ggplot mean slightly different things by 'color', and Makie doesn't seem to have a concept of fill. Rather, color is the primary color always in Makie, and things that would be color in ggplot are referred to as strokecolor or similar.

Makie's way of referring to colors is frankly better in my opinion, but the goals of the package require fealty to ggplot, so scale_fill must be implemented ...

  • map ggplot color and fill to equivalent arguments in Makie, must be done on a per geom basis
  • implement scale_fill_manual
  • implement scale_fill_discrete
  • implement scale_fill_continuous
  • implement scale_fill_binned
@rdboyes rdboyes mentioned this issue Apr 15, 2024
8 tasks
@rdboyes rdboyes added the enhancement New feature or request label Apr 15, 2024
@rdboyes rdboyes added this to the v0.8.0 milestone Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant