Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Allow CustomPhaseCommand to check if Solving Terminated Early #1200

Open
Christopher-Chianelli opened this issue Nov 12, 2024 · 0 comments
Labels
enhancement New feature or request process/needs triage Requires initial assessment of validity, priority etc.

Comments

@Christopher-Chianelli
Copy link
Contributor

Is your feature request related to a problem? Please describe.

A CustomPhaseCommand may take a long time to execute. As a result, there can be a long delay between when terminateEarly is called and when the Solver actually terminates since the Solver has to wait for the CustomPhaseCommand to finish.

Describe the solution you'd like

A method for a CustomPhaseCommand to check if solving was terminated so it can return early. These can include:

  • Interrupting the Solver Thread
  • Adding a new method to Score Director
  • Adding a new method to Phase that is called by terminateEarly

Describe alternatives you've considered

See above.

Additional context

#1199

@Christopher-Chianelli Christopher-Chianelli added enhancement New feature or request process/needs triage Requires initial assessment of validity, priority etc. labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request process/needs triage Requires initial assessment of validity, priority etc.
Projects
None yet
Development

No branches or pull requests

1 participant