Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal Page issue #18

Open
ScarletKuro opened this issue Apr 1, 2021 · 0 comments
Open

Modal Page issue #18

ScarletKuro opened this issue Apr 1, 2021 · 0 comments

Comments

@ScarletKuro
Copy link

If you use _navigationHelper.OpenModalAsync(someview, true) then if you somehow close the modal page without _navigationHelper.CloseModalAsync() method then the NavigateToAsync on mainpage won't be possible, because the private NavigationPage? _modalNavigationPage in FormsNavigationHelper is not null.
As you can see on example below I navigated back using the android back button. which caused this. This also means if you use NavigationHelper OpenModal method with withNavigation parameter you are forced to close the modal only using the NavigationHelper CloseModal method, otherwise your navigation will get broken.
Example

Ideas:
1.Provide additional parameter in NavigateToAsync that will set internally _modalNavigationPage to null.
2.Somehow to check in modal navigation stack if modalNavigationPage doesn't exist anymore we skip it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant