From 9448ffbb607d7826f09050a8579037bc3e1dd3a0 Mon Sep 17 00:00:00 2001 From: Cameron <60164098+cameron-emburse@users.noreply.github.com> Date: Wed, 14 Feb 2024 13:55:29 -0500 Subject: [PATCH 1/2] Update cron.py to remove import of missing dependency This currently prevents `FailedRunsNotificationCronJob` from running. --- django_cron/cron.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/django_cron/cron.py b/django_cron/cron.py index 8d65f49..36dc3e6 100644 --- a/django_cron/cron.py +++ b/django_cron/cron.py @@ -1,6 +1,5 @@ from django.conf import settings - -from django_common.helper import send_mail +from django.core.mail import send_mail from django_cron import CronJobBase, Schedule, get_class from django_cron.models import CronJobLog From 7ce09c65e65020fb408d67821f062a3c16575ecb Mon Sep 17 00:00:00 2001 From: Cameron Lakenen Date: Wed, 14 Feb 2024 14:31:32 -0500 Subject: [PATCH 2/2] Don't skip test_failed_runs_notification --- django_cron/tests.py | 1 - 1 file changed, 1 deletion(-) diff --git a/django_cron/tests.py b/django_cron/tests.py index 9691b4f..68ab2db 100644 --- a/django_cron/tests.py +++ b/django_cron/tests.py @@ -307,7 +307,6 @@ def test_cache_locking_backend(self): # t.join(10) # self.assertEqual(CronJobLog.objects.all().count(), logs_count + 1) - @skip # TODO check why the test is failing def test_failed_runs_notification(self): CronJobLog.objects.all().delete()