Remote Sending to Actor with DNS name error

[incizzle]

Bug description
Due to a recent change in https://github.com/Tochemey/goakt/blob/main/actors/actor_system.go#L1528 this now causes remote message sending to fail due to actor not having DNS name in id. Removing the call to this function resolves this issue.

How to reproduce it?
Set actor remote host to a DNS name and attempt a send from another actor on network to that DNS name.

Expected behavior
Should use DNS name for actors instead of resolved ip in id

Screenshots

Library Version:

• Go-Akt version: 2.8.2
• Go version: 1.23

Additional context

[Tochemey]

@incizzle this code is not new though. It has been around since version 2.6.0. Has it been working before? I don't mind fixing it.

[Tochemey]

@incizzle I have been able to reproduce it with one of the test. I push a fix in the course of the day.

[Tochemey]

@incizzle I will run more tests and cut a release today or morrow. Once again thanks for the findin

[incizzle]

Thank you for the quick help with this. Goakt has been a great pkg looking forward to future updates 🫡

[Tochemey]

@incizzle I have cut a new release https://github.com/Tochemey/goakt/releases/tag/v2.8.3. Thanks for the feedback. Kindly star the repo if you have not :)

[Tochemey]

@incizzle the DNS feature introduced some sort of issue with the clustering discovery engine. At the moment the hashicorp memberlist library does not handle well DNS. You can see some issues opened here:

• Using DNS names in Config.AdvertiseAddr hashicorp/memberlist#162
• Join() fails to resolve unqualified DNS name hashicorp/memberlist#147

I have reverted the changes to make sure the clustering engine works well in the new release https://github.com/Tochemey/goakt/releases/tag/v2.9.1. You can see how GoAkt handle the host address here

I hope to look into the DNS option at some point. I have an issue here to properly tackle it.

[incizzle]

@incizzle the DNS feature introduced some sort of issue with the clustering discovery engine. At the moment the hashicorp memberlist library does not handle well DNS. You can see some issues opened here:

• Using DNS names in Config.AdvertiseAddr hashicorp/memberlist#162
• Join() fails to resolve unqualified DNS name hashicorp/memberlist#147

I have reverted the changes to make sure the clustering engine works well in the new release https://github.com/Tochemey/goakt/releases/tag/v2.9.1. You can see how GoAkt handle the host address here

I hope to look into the DNS option at some point. I have an issue here to properly tackle it.

Ok sounds good thanks for letting me know we ended up not needed remote messaging for our production app yet so this is fine on our side. Look forward to finding a solution to this eventually