Skip to content

Commit 7e57328

Browse files
committed
docs(toxav): fix docs of toxav.h
- fix units to be more readable - use width before height consistently - video -> audio typo
1 parent 5f88a08 commit 7e57328

File tree

1 file changed

+16
-15
lines changed

1 file changed

+16
-15
lines changed

Diff for: toxav/toxav.h

+16-15
Original file line numberDiff line numberDiff line change
@@ -249,9 +249,9 @@ typedef enum Toxav_Err_Call {
249249
* receiving are both enabled by default.
250250
*
251251
* @param friend_number The friend number of the friend that should be called.
252-
* @param audio_bit_rate Audio bit rate in Kb/sec. Set this to 0 to disable
252+
* @param audio_bit_rate Audio bit rate in kbit/sec. Set this to 0 to disable
253253
* audio sending.
254-
* @param video_bit_rate Video bit rate in Kb/sec. Set this to 0 to disable
254+
* @param video_bit_rate Video bit rate in kbit/sec. Set this to 0 to disable
255255
* video sending.
256256
*/
257257
bool toxav_call(ToxAV *av, uint32_t friend_number, uint32_t audio_bit_rate, uint32_t video_bit_rate,
@@ -318,9 +318,9 @@ typedef enum Toxav_Err_Answer {
318318
* enabled by default.
319319
*
320320
* @param friend_number The friend number of the friend that is calling.
321-
* @param audio_bit_rate Audio bit rate in Kb/sec. Set this to 0 to disable
321+
* @param audio_bit_rate Audio bit rate in kbit/sec. Set this to 0 to disable
322322
* audio sending.
323-
* @param video_bit_rate Video bit rate in Kb/sec. Set this to 0 to disable
323+
* @param video_bit_rate Video bit rate in kbit/sec. Set this to 0 to disable
324324
* video sending.
325325
*/
326326
bool toxav_answer(ToxAV *av, uint32_t friend_number, uint32_t audio_bit_rate, uint32_t video_bit_rate,
@@ -600,11 +600,11 @@ bool toxav_audio_send_frame(ToxAV *av, uint32_t friend_number, const int16_t pcm
600600
uint8_t channels, uint32_t sampling_rate, Toxav_Err_Send_Frame *error);
601601

602602
/**
603-
* Set the bit rate to be used in subsequent video frames.
603+
* Set the bit rate to be used in subsequent audio frames.
604604
*
605605
* @param friend_number The friend number of the friend for which to set the
606606
* bit rate.
607-
* @param bit_rate The new audio bit rate in Kb/sec. Set to 0 to disable.
607+
* @param bit_rate The new audio bit rate in kbit/sec. Set to 0 to disable.
608608
*
609609
* @return true on success.
610610
*/
@@ -617,7 +617,7 @@ bool toxav_audio_set_bit_rate(ToxAV *av, uint32_t friend_number, uint32_t bit_ra
617617
*
618618
* @param friend_number The friend number of the friend for which to set the
619619
* bit rate.
620-
* @param audio_bit_rate Suggested maximum audio bit rate in Kb/sec.
620+
* @param audio_bit_rate Suggested maximum audio bit rate in kbit/sec.
621621
*/
622622
typedef void toxav_audio_bit_rate_cb(ToxAV *av, uint32_t friend_number, uint32_t audio_bit_rate, void *user_data);
623623

@@ -630,9 +630,10 @@ void toxav_callback_audio_bit_rate(ToxAV *av, toxav_audio_bit_rate_cb *callback,
630630
/**
631631
* Send a video frame to a friend.
632632
*
633-
* Y - plane should be of size: `height * width`
634-
* U - plane should be of size: `(height/2) * (width/2)`
635-
* V - plane should be of size: `(height/2) * (width/2)`
633+
* The video frame needs to be planar YUV420.
634+
* Y - plane should be of size: `width * height`
635+
* U - plane should be of size: `(width/2) * (height/2)`
636+
* V - plane should be of size: `(width/2) * (height/2)`
636637
*
637638
* @param friend_number The friend number of the friend to which to send a video
638639
* frame.
@@ -644,17 +645,17 @@ void toxav_callback_audio_bit_rate(ToxAV *av, toxav_audio_bit_rate_cb *callback,
644645
*/
645646
bool toxav_video_send_frame(
646647
ToxAV *av, uint32_t friend_number, uint16_t width, uint16_t height,
647-
const uint8_t y[/*! height * width */],
648-
const uint8_t u[/*! height/2 * width/2 */],
649-
const uint8_t v[/*! height/2 * width/2 */],
648+
const uint8_t y[/*! width * height */],
649+
const uint8_t u[/*! width/2 * height/2 */],
650+
const uint8_t v[/*! width/2 * height/2 */],
650651
Toxav_Err_Send_Frame *error);
651652

652653
/**
653654
* Set the bit rate to be used in subsequent video frames.
654655
*
655656
* @param friend_number The friend number of the friend for which to set the
656657
* bit rate.
657-
* @param bit_rate The new video bit rate in Kb/sec. Set to 0 to disable.
658+
* @param bit_rate The new video bit rate in kbit/sec. Set to 0 to disable.
658659
*
659660
* @return true on success.
660661
*/
@@ -667,7 +668,7 @@ bool toxav_video_set_bit_rate(ToxAV *av, uint32_t friend_number, uint32_t bit_ra
667668
*
668669
* @param friend_number The friend number of the friend for which to set the
669670
* bit rate.
670-
* @param video_bit_rate Suggested maximum video bit rate in Kb/sec.
671+
* @param video_bit_rate Suggested maximum video bit rate in kbit/sec.
671672
*/
672673
typedef void toxav_video_bit_rate_cb(ToxAV *av, uint32_t friend_number, uint32_t video_bit_rate, void *user_data);
673674

0 commit comments

Comments
 (0)