Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make tox use loopback device on linux when UDP and local lan is turned on #2749

Open
zoff99 opened this issue Apr 5, 2024 · 1 comment · May be fixed by #2760
Open

make tox use loopback device on linux when UDP and local lan is turned on #2749

zoff99 opened this issue Apr 5, 2024 · 1 comment · May be fixed by #2760
Labels
enhancement New feature for the user, not a new feature for build script
Milestone
v0.2.x

Comments

@zoff99
Copy link

zoff99 commented Apr 5, 2024 •
edited
Loading

now tox is not using lo: (loopback) 127.0.0.1 to connect to devices on the same host. even when UDP and local lan is turned on.
now tox will only listen on the eth0: device (or whatever your LAN device is called)
loopback can get much higher transfer speeds than LAN.

this shows a hackish PoC how to enable 127.0.0.1
https://gist.github.com/zoff99/f8d605514a89d995c526bd6577a49051
(but this ONLY uses 127.0.0.1 and no other network device)

we should add an enhancement to detect local loopback device and make tox also listen on that for connections.
and probably the same for the other direction (trying to connect to a node on local loopback)
@zoff99 zoff99 added the enhancement New feature for the user, not a new feature for build script label Apr 5, 2024
@iacore
Copy link

iacore commented Jul 10, 2024 •
edited
Loading

I traced the problem back to LAN_discovery.c:186 in lldb.

        if (ip->ip.v4.uint32 == 0) {
            continue; // this line gets run
        }

Basically, lo has no broadcast address. It should be handled differently here.

@iacore iacore linked a pull request Jul 10, 2024 that will close this issue
Open
@iphydf iphydf added this to the v0.2.x milestone Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature for the user, not a new feature for build script
Projects
None yet
Milestone
v0.2.x
Development

Successfully merging a pull request may close this issue.

fix: Fake broadcast address for 127.x.x.x iacore/c-toxcore
3 participants
@zoff99 @iphydf @iacore