Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code samples in the demo page #248

Open
MaxDesiatov opened this issue Aug 4, 2020 · 1 comment
Open

Code samples in the demo page #248

MaxDesiatov opened this issue Aug 4, 2020 · 1 comment
Labels
documentation Technical writing, references, tutorials etc enhancement New feature or request

Comments

@MaxDesiatov
Copy link
Collaborator

I know it's going to be hard as the demo code would become self-referential that way. Maybe we could upload the demo code to release assets (it would be served through GitHub CDN then), and then the running demo would download that archive, unpack it and display each file's source code in a separate "tab"? But then there's a question of adding a new dependency for .zip support just in the demo. Maybe it's time to move the demo code into a separate repository so that we could add more dependencies to it 🤔

I would still prefer a monorepo though, the main benefit is that it's easier to add demos for in-progress and unreleased features that way.
@MaxDesiatov MaxDesiatov added enhancement New feature or request documentation Technical writing, references, tutorials etc labels Aug 4, 2020
@MaxDesiatov
Copy link
Collaborator Author

We could use something like JohnSundell/Splash#92 for syntax highlighting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Technical writing, references, tutorials etc enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MaxDesiatov